Closed Bug 1141317 Opened 10 years ago Closed 10 years ago

Link text is too dark in reader view dark theme

Categories

(Firefox for Android Graveyard :: Reader View, defect)

Product:
Firefox for Android Graveyard
Component:
Reader View
Version:
35 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 verified, firefox39 verified, fennec38+)

Status:
VERIFIED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- verified
fennec 38+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Screenshot from 2015-03-12 15:25:42.png
182.08 KB, image/png
Details
MozReview Request: Bug 1141317 - Account for new #container div in about:reader CSS. r=bnicholson
39 bytes, text/x-review-board-request
bnicholson
: review+
Details
This must have regressed somewhere. antlam, what color should links be in the light/dark reader view themes?
Flags: needinfo?(alam)
Ah, this was caused by bug 1120004, because I changed the mark-up, but I didn't account for that in the CSS :/
Blocks: 1120004
This regression also affects desktop. I'll just write a patch to revert it to the way it was (#00acff for links on mobile).
Flags: needinfo?(alam)
/r/5061 - Bug 1141317 - Account for new #container div in about:reader CSS. r=bnicholson Pull down this commit: hg pull review -r 45bcbdc1a9c2a3371b89c5cd17cf6183e939e40a
Attachment #8575018 - Flags: review?(bnicholson)
Comment on attachment 8575018 [details] MozReview Request: bz://1141317/margaret https://reviewboard.mozilla.org/r/5059/#review4079 Ship It!
Attachment #8575018 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/b66bc9617e80
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Tested with: Device: Nexus 4 (Android 4.4) Build: Firefox for Android 39.0a1 (2015-03-12) Link text are displayed in a lighter blue in reader view dark theme.
Link text is displayed in a lighter blue in reader view dark theme, so: Verified fixed using: Device: Nexus 4 (Android 4.4) Build: Firefox for Android 38.0a2 (2015-03-18)
Status: RESOLVED → VERIFIED
status-firefox38: fixed → verified
Attachment #8575018 - Attachment is obsolete: true
Attachment #8619708 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: