Closed Bug 1141346 Opened 7 years ago Closed 7 years ago

[e10s] "This Frame" > "Reload Frame" in remote browser causes unsafe CPOW usage warning

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
e10s m8+ ---
firefox40 --- fixed

People

(Reporter: Kwan, Assigned: Kwan)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with a frame in it in an e10s window
2) Right-click in the frame, and choose "This Frame" > "Reload Frame"

This causes an "unsafe CPOW usage" warning in the Browser Console.

In browser/base/content/nsContextMenu.js:

  // Reload clicked-in frame.
  reloadFrame: function() {
    this.target.ownerDocument.location.reload(); <-- Causes CPOW warning
  },
Assignee: nobody → moz-ian
Status: NEW → ASSIGNED
Attached file MozReview Request: bz://1141346/Kwan (obsolete) —
/r/5825 - Bug 1141346 - Make 'This Frame' > 'Reload Frame' use messages to avoid unsafe CPOW usage

Pull down this commit:

hg pull review -r 0d22b0eca9dca0d168696862f2b6a0df1f271b80
Attachment #8581671 - Flags: review?(mconley)
Attachment #8581671 - Flags: review?(mconley) → review?(gkrizsanits)
Comment on attachment 8581671 [details]
MozReview Request: bz://1141346/Kwan

https://reviewboard.mozilla.org/r/5823/#review5207

Ship It!
Attachment #8581671 - Flags: review?(gkrizsanits) → review+
https://hg.mozilla.org/mozilla-central/rev/80e95d56aadd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Attachment #8581671 - Attachment is obsolete: true
Attachment #8619709 - Flags: review+
You need to log in before you can comment on or make changes to this bug.