1141346 - [e10s] "This Frame" > "Reload Frame" in remote browser causes unsafe CPOW usage warning

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Ian Moody [:Kwan] (UTC+1)]

+++ This bug was initially created as a clone of Bug #1133577 +++

STR:

1) Visit a site with a frame in it in an e10s window
2) Right-click in the frame, and choose "This Frame" > "Reload Frame"

This causes an "unsafe CPOW usage" warning in the Browser Console.

In browser/base/content/nsContextMenu.js:

  // Reload clicked-in frame.
  reloadFrame: function() {
    this.target.ownerDocument.location.reload(); <-- Causes CPOW warning
  },

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: MozReview Request: bz://1141346/Kwan

/r/5825 - Bug 1141346 - Make 'This Frame' > 'Reload Frame' use messages to avoid unsafe CPOW usage

Pull down this commit:

hg pull review -r 0d22b0eca9dca0d168696862f2b6a0df1f271b80

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8581671 [details]
MozReview Request: bz://1141346/Kwan

https://reviewboard.mozilla.org/r/5823/#review5207

Ship It!

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d156d77e1b0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/80e95d56aadd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80e95d56aadd

Comment 7

[Ian Moody [:Kwan] (UTC+1)]

Attachment: MozReview Request: Bug 1141346 - Make 'This Frame' > 'Reload Frame' use messages to avoid unsafe CPOW usage