Reuse the same thread when we start/stop vsync event for the windows vsync thread

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

unspecified
mozilla39
All
Windows 7
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1139253 +++

+++ This bug was initially created as a clone of Bug #1102631 +++

Currently, we call base::Thread::Start()/Stop() when we enable/disable the vsync thread. This will create/delete the thread for Start()/Stop() in the underlying platform. Just reuse the same thread.
(Assignee)

Comment 1

4 years ago
Created attachment 8574994 [details] [diff] [review]
Reuse the same thread for the vsync thread

Just start / stop the thread once during construction / destruction of the object. Otherwise, we just set the mEnabledVsync flag, which should put the thread to sleep.
Attachment #8574994 - Flags: review?(jmuizelaar)
Attachment #8574994 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/fc18e8a9f98d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.