If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Line terminator incorrectly allowed after arrow function arguments

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shu, Assigned: ziyunfei)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla39
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [DocArea=JS])

Attachments

(1 attachment, 1 obsolete attachment)

21.34 KB, patch
ziyunfei
: review+
Details | Diff | Splinter Review
(Reporter)

Description

3 years ago
The production for ArrowFunction specifies no line terminator after the args [1].

We currently parse

  var fn = (a)
  => 1

[1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions

Thanks for caitp from #jslang for pointing this out!
(Assignee)

Updated

3 years ago
(Assignee)

Updated

3 years ago
Blocks: 694100
(Assignee)

Comment 1

3 years ago
Created attachment 8576717 [details] [diff] [review]
bug-1141392-v1.patch
Attachment #8576717 - Flags: review?(jorendorff)
Comment on attachment 8576717 [details] [diff] [review]
bug-1141392-v1.patch

Review of attachment 8576717 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch!
Attachment #8576717 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8577721 [details] [diff] [review]
bug-1141392-v2.patch

Fixed one devtools test failure.
Attachment #8576717 - Attachment is obsolete: true
Attachment #8577721 - Flags: review+
(Assignee)

Comment 4

3 years ago
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a482f4be30f
Assignee: nobody → 446240525
Keywords: checkin-needed, dev-doc-needed
Whiteboard: [DocArea=JS]
https://hg.mozilla.org/integration/mozilla-inbound/rev/66c780b6b377
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/66c780b6b377
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
https://developer.mozilla.org/en-US/Firefox/Releases/39#JavaScript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Firefox-specific_notes
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.