Closed
Bug 1141392
Opened 9 years ago
Closed 9 years ago
Line terminator incorrectly allowed after arrow function arguments
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: shu, Assigned: 446240525)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [DocArea=JS])
Attachments
(1 file, 1 obsolete file)
|
21.34 KB,
patch
|
446240525
:
review+
|
Details | Diff | Splinter Review |
The production for ArrowFunction specifies no line terminator after the args [1]. We currently parse var fn = (a) => 1 [1] https://people.mozilla.org/~jorendorff/es6-draft.html#sec-arrow-function-definitions Thanks for caitp from #jslang for pointing this out!
Attachment #8576717 -
Flags: review?(jorendorff)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8576717 [details] [diff] [review] bug-1141392-v1.patch Review of attachment 8576717 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for the patch!
Attachment #8576717 -
Flags: review?(jorendorff) → review+
Fixed one devtools test failure.
Attachment #8576717 -
Attachment is obsolete: true
Attachment #8577721 -
Flags: review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/66c780b6b377
Keywords: checkin-needed
|
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66c780b6b377
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Comment 7•9 years ago
|
||
https://developer.mozilla.org/en-US/Firefox/Releases/39#JavaScript https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Firefox-specific_notes
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•