Closed Bug 1141617 Opened 9 years ago Closed 9 years ago

Uplift to 38 suggested tiles string changes as code

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal
Points:
3

Tracking

()

RESOLVED FIXED
Iteration:
40.1 - 13 Apr
Tracking Status
firefox38 + fixed
firefox39 + unaffected

People

(Reporter: Mardak, Assigned: emtwo)

References

Details

(Whiteboard: .001)

Attachments

(3 files)

There will be various string changes needed for the affiliate suggested tiles bug 1120311. We'll want to land strings in Nightly 39 to uplift to Aurora 38 to avoid trying to uplift to string frozen Beta 38.
Depends on: 1126186, 1126188
[Tracking Requested - why for this release]: Request to uplift tracking bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1120311, into Aurora 38 from Nightly 39 for the release of Suggested Tiles for internal Mozilla partners only. Reasons for uplift to 38 are:

- Provide scale for the Fennec for Android campaign in addition to our own/operated Snippets on about:home and Directory Tiles campaigns
- Provide introduction personalized tiles delivery based on increased contextual relevancy
- Provide tiles scheduling and servering efficiencies to internal and external clients by reducing cost of acquisition/action
Tracking this for 38. 

Ed, you may want to talk with Axel to see what your options are, since strings are already frozen in aurora.
Flags: needinfo?(l10n)
This is for En-US local/geo only.
As kghim notes, the functionality in Firefox 38 is only for en-US users in particular those in US. We can code the changes in a way that don't touch string files for landing on Aurora 38 or Beta 38. So even if we got approval to land string changes on Aurora 38, we probably would want to avoid unnecessary localization rush for strings that users outside of en-US wouldn't see.
Agreed, in particular as localizers wouldn't be able to test the strings, and might forget in 39.

Makes this bug WONTFIX?
Flags: needinfo?(l10n)
emtwo, when we uplift the functionality to 38, we need to make sure to not touch (add/remove/edit) dtd/properties files. This also means we need to change some usages of dtd/&entities to load from js.

Here's an example of the differences between using dtd and js:

https://bugzilla.mozilla.org/attachment.cgi?id=8477760&action=diff

We used to have a newTabString function to get the appropriate string:
https://hg.mozilla.org/releases/mozilla-aurora/annotate/ba7f43e4427a/browser/base/content/newtab/newTab.js#l38

For this bug, write the patch as if against mozilla-central (so there'll be additions to .dtd and removal from .dtd), and when we uplift, we'll merge the patch in to a single changeset, so it'll appear as if there's no changes to the .dtd.
Summary: Land suggested tiles string changes for uplift to Aurora 38 → Land suggested tiles string changes as code for uplift to Aurora 38
Assignee: nobody → msamuel
(In reply to Marina Samuel [:emtwo] from comment #7)
> Created attachment 8584003 [details] [diff] [review]
> Bug 1126186 uplift for cog menu string changes

This doesn't make any sense based on comment 4 and following.

> emtwo, when we uplift the functionality to 38, we need to make sure to not
> touch (add/remove/edit) dtd/properties files. This also means we need to
> change some usages of dtd/&entities to load from js.
Ed, do these patches look like what we want? What would be the next steps for getting these reviewed/uplifted? Thanks!

Francesco, I built the patches to be on top of the patches of the respective bugs mentioned in them. Those bugs had already made string changes but the patches here undo those string changes so that when they're merged and uplifted together there would be no string changes.
Flags: needinfo?(edilee)
(In reply to Marina Samuel [:emtwo] from comment #11) 
> Francesco, I built the patches to be on top of the patches of the respective
> bugs mentioned in them. Those bugs had already made string changes but the
> patches here undo those string changes so that when they're merged and
> uplifted together there would be no string changes.

Argh, sorry for the unnecessary confusion, I didn't realize it was reverting the string changes and was expecting a full patch for mozilla-aurora.
(In reply to Marina Samuel [:emtwo] from comment #11)
> Ed, do these patches look like what we want? What would be the next steps
> for getting these reviewed/uplifted? Thanks!
The patches look good. I would r?adw for each of these 3 patches. If good, attach the combined "for aurora uplift" patch in each of the dependent bug where we'll need to a-aurora? to land on aurora.
Depends on: 1143797
Flags: needinfo?(edilee)
Attachment #8584003 - Flags: review?(adw)
Attachment #8584005 - Flags: review?(adw)
Attachment #8584007 - Flags: review?(adw)
Attachment #8584003 - Flags: review?(adw) → review+
Attachment #8584005 - Flags: review?(adw) → review+
Attachment #8584007 - Flags: review?(adw) → review+
The various strings were uplifted 38 as code instead of string files.

bug 1126188 https://hg.mozilla.org/releases/mozilla-beta/rev/e9021ea8d7ca
bug 1126186 https://hg.mozilla.org/releases/mozilla-beta/rev/db2b58500934
bug 1143797 https://hg.mozilla.org/releases/mozilla-beta/rev/65f2aa5f2dd7

The strings landed as normal for 39.
Status: NEW → RESOLVED
Iteration: --- → 40.1 - 13 Apr
Points: --- → 3
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Land suggested tiles string changes as code for uplift to Aurora 38 → Uplift to 38 suggested tiles string changes as code
Blocks: 1155443
No longer blocks: 1155443
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: