Delayed process scripts at chrome URLs aren't loaded in new processes

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: mossop, Assigned: mrbkap)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(e10sm6+, firefox40 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Because we send the chrome registry across after we attempt to load process scripts in a new process any process script at a chrome URL can't be found.
Assignee: nobody → wmccloskey
tracking-e10s: --- → ?
Assignee: wmccloskey → mrbkap
tracking-e10s: ? → m6+
I see two ways to fix this:

  1. Try to delay loading frame scripts until later in PContent startup (that is, after we register chrome).
  2. Remember any chrome:-protocol'd scripts that failed to resolve in the child and try to re-resolve them when we register new chrome. This seems safer, but I don't know if we want to allow buggy extensions to accidentally load frame scripts before they register their chrome.

Olli, any additional thoughts? My initial reaction is to implement option 2.
Flags: needinfo?(bugs)

Comment 2

3 years ago
So, we should move chrome registry sending to happen earlier, right?
(kind of a variant of 1)


2. sounds super weird and error prone.
Flags: needinfo?(bugs)
(Reporter)

Comment 3

3 years ago
Seems like it would be straightforward to do 1. Sending the process scripts and sending the chrome registry both happen synchronously from ContentParent::InitInternal so we just need to flip the order no?
Created attachment 8594185 [details] [diff] [review]
Remove workaround
Attachment #8594185 - Flags: review?(dtownsend)

Updated

3 years ago
Attachment #8594184 - Flags: review?(bugs) → review+
(Reporter)

Updated

3 years ago
Attachment #8594185 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/43f77c634a8b
https://hg.mozilla.org/mozilla-central/rev/87048f5c4e77
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.