1141796 - [e10s] SDK add-ons somehow break console.assert in web content

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Install Whimsy (https://addons.mozilla.org/en-US/firefox/addon/whimsycorn/)
2) Visit https://reviewboard.mozilla.org/r/4319/diff/

ER:

All diffs should load

AR:

Some diffs don't load, and just show a forever-spinner.

There's also this error in the web console:

TypeError: console.assert is not a function

Disabling Whimsy fixes the issue. This doesn't seem to be restricted to Whimsy - 1Password apparently does this too. Mossop suspects that this is a pagemod bug.

Comment 1

[Dave Townsend [:mossop] (PTO until Aug 21st)]

We should see how this does after bug 1139189 is fixed, there are a bunch of page-mod tests about to land.

Comment 2

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Need to recheck this now bug 1139189 has landed

Comment 3

[David Burns :automatedtester]

just hit this trying to a review on MozREview. 

Addons installed are 

Adblock Plus	2.6.8	true	{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}
Buffer	2.8.3	true	jid1-zUyU7TGKwejAyA@jetpack
DuckDuckGo Plus	0.4.6	true	jid1-ZAdIEUB7XOzOJw@jetpack
Firefox OS Simulator	4.0.2	true	[e-mail]
Ghostery	5.4.3	true	[e-mail]
Github Tweaks for Bugzilla	1.40	true	jid0-AWShpy08txla2QGDYvv5bed4sjs@jetpack
Github+Travis	0.2.6	true	[e-mail]
Greasemonkey	2.3	true	{e4a8a97b-f2ed-450b-b12d-ee082ba24781}
LastPass	3.1.92	true	[e-mail]
Lightbeam	1.2.1	true	jid1-F9UJ2thwoAm5gQ@jetpack
Test Pilot	1.2.3	true	[e-mail]
Evernote Web Clipper	5.9.1	false	{E0B8C461-F8FB-49b4-8373-FE32E9252800}
Firefox Certificate Store Hotfix	20150225.01	false	[e-mail]
Pocket	3.0.6	false	[e-mail]
Whimsy Pro	1.0.8	false	jid1-6mUPixNFCjAgkg@jetpack

Comment 4

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Not fixed by the uplift apparently

Comment 5

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Attachment: pull request

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/db2c648802c83c68b8ee104e8a0407c2222d3d33
Bug 1141796: Don't inject the SDK console into pages loaded in tabs.

https://github.com/mozilla/addon-sdk/commit/2e498b49b79ecf087a23683219fce80102598e01
Merge pull request #1897 from Mossop/bug1141796

Bug 1141796: Don't inject the SDK console into pages loaded in tabs. r=erikvold

Comment 7

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Did a direct uplift as this is breaking some websites: https://hg.mozilla.org/integration/fx-team/rev/b8b1d58af8c6

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8b1d58af8c6