[e10s] SDK add-ons somehow break console.assert in web content

RESOLVED FIXED

Status

defect
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mossop)

Tracking

unspecified
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(e10s?)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
STR:

1) Install Whimsy (https://addons.mozilla.org/en-US/firefox/addon/whimsycorn/)
2) Visit https://reviewboard.mozilla.org/r/4319/diff/

ER:

All diffs should load

AR:

Some diffs don't load, and just show a forever-spinner.

There's also this error in the web console:

TypeError: console.assert is not a function

Disabling Whimsy fixes the issue. This doesn't seem to be restricted to Whimsy - 1Password apparently does this too. Mossop suspects that this is a pagemod bug.
We should see how this does after bug 1139189 is fixed, there are a bunch of page-mod tests about to land.
Depends on: 1139189
Blocks: e10s-sdk
Priority: -- → P1
Need to recheck this now bug 1139189 has landed
Flags: needinfo?(dtownsend)
just hit this trying to a review on MozREview. 

Addons installed are 

Adblock Plus	2.6.8	true	{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}
Buffer	2.8.3	true	jid1-zUyU7TGKwejAyA@jetpack
DuckDuckGo Plus	0.4.6	true	jid1-ZAdIEUB7XOzOJw@jetpack
Firefox OS Simulator	4.0.2	true	r2d2b2g@mozilla.org
Ghostery	5.4.3	true	firefox@ghostery.com
Github Tweaks for Bugzilla	1.40	true	jid0-AWShpy08txla2QGDYvv5bed4sjs@jetpack
Github+Travis	0.2.6	true	githubtravis@theautomatedtester.co.uk
Greasemonkey	2.3	true	{e4a8a97b-f2ed-450b-b12d-ee082ba24781}
LastPass	3.1.92	true	support@lastpass.com
Lightbeam	1.2.1	true	jid1-F9UJ2thwoAm5gQ@jetpack
Test Pilot	1.2.3	true	testpilot@labs.mozilla.com
Evernote Web Clipper	5.9.1	false	{E0B8C461-F8FB-49b4-8373-FE32E9252800}
Firefox Certificate Store Hotfix	20150225.01	false	firefox-hotfix@mozilla.org
Pocket	3.0.6	false	isreaditlater@ideashower.com
Whimsy Pro	1.0.8	false	jid1-6mUPixNFCjAgkg@jetpack
Not fixed by the uplift apparently
Assignee: nobody → dtownsend
No longer depends on: 1139189
Flags: needinfo?(dtownsend)
Posted file pull request
Status: NEW → ASSIGNED
Attachment #8577398 - Flags: review?(evold)
Attachment #8577398 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/db2c648802c83c68b8ee104e8a0407c2222d3d33
Bug 1141796: Don't inject the SDK console into pages loaded in tabs.

https://github.com/mozilla/addon-sdk/commit/2e498b49b79ecf087a23683219fce80102598e01
Merge pull request #1897 from Mossop/bug1141796

Bug 1141796: Don't inject the SDK console into pages loaded in tabs. r=erikvold
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Did a direct uplift as this is breaking some websites: https://hg.mozilla.org/integration/fx-team/rev/b8b1d58af8c6
You need to log in before you can comment on or make changes to this bug.