1141914 - Don't use demuxer's metadata dimensions.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Following bug 1128381, for pure AVCC data and outside the SharedDecoderManager we don't always use the picture dimension and aspect ratio found in the SPS NAL, but instead rely on the demuxer's metadata.

We should always use the SPS decoded data.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Always use video dimensions using extradata's SPS

Always use decoded SPS and do not rely on demuxer's metadata for video/display dimensions

Comment 2

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/54f1419ebdfa

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54f1419ebdfa

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8575778 [details] [diff] [review]
Always use video dimensions using extradata's SPS

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Videos may not have the correct aspect ratio after the quality of stream/video/bitrate increases.
[Describe test coverage new/current, TreeHerder]: Local testing on partner site. We're working on a mochitest to cover stream switching too, but it's not ready yet.
[Risks and why]: Low risk, this keeps the data we hand the decoder more up to date, so shouldn't cause issue.
[String/UUID change made/needed]: None

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8575778 [details] [diff] [review]
Always use video dimensions using extradata's SPS

We can take the uplift for Aurora at this stage, but please ensure there's mochitest(s) for Beta.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Aurora.

Comment 7

[Jean-Yves Avenard [:jya]]

On its own this bug isn't very useful. It won't work without part of 1128381. Should I include those parts? going to make it a pain to uplift the rest

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Bug 1128381 is on Aurora already. Some other dep?

Comment 9

[Jean-Yves Avenard [:jya]]

It's missing bug 1139779. Will request uplift of that one

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

Try of Aurora uplift:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1fb645a5a9e

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4acd7286be9e