Closed Bug 1141914 Opened 5 years ago Closed 5 years ago

Don't use demuxer's metadata dimensions.

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox38 + fixed
firefox39 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Following bug 1128381, for pure AVCC data and outside the SharedDecoderManager we don't always use the picture dimension and aspect ratio found in the SPS NAL, but instead rely on the demuxer's metadata.

We should always use the SPS decoded data.
Always use decoded SPS and do not rely on demuxer's metadata for video/display dimensions
Attachment #8575778 - Flags: review?(cpearce)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8575778 - Flags: review?(cpearce) → review+
Flags: needinfo?(cpearce)
https://hg.mozilla.org/mozilla-central/rev/54f1419ebdfa
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8575778 [details] [diff] [review]
Always use video dimensions using extradata's SPS

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Videos may not have the correct aspect ratio after the quality of stream/video/bitrate increases.
[Describe test coverage new/current, TreeHerder]: Local testing on partner site. We're working on a mochitest to cover stream switching too, but it's not ready yet.
[Risks and why]: Low risk, this keeps the data we hand the decoder more up to date, so shouldn't cause issue.
[String/UUID change made/needed]: None
Attachment #8575778 - Flags: approval-mozilla-aurora?
Comment on attachment 8575778 [details] [diff] [review]
Always use video dimensions using extradata's SPS

We can take the uplift for Aurora at this stage, but please ensure there's mochitest(s) for Beta.
Attachment #8575778 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Needs rebasing for Aurora.
Flags: needinfo?(jyavenard)
On its own this bug isn't very useful. It won't work without part of 1128381. Should I include those parts? going to make it a pain to uplift the rest
Flags: needinfo?(jyavenard) → needinfo?(ryanvm)
Bug 1128381 is on Aurora already. Some other dep?
Flags: needinfo?(ryanvm)
Flags: needinfo?(jyavenard)
It's missing bug 1139779. Will request uplift of that one
Flags: needinfo?(jyavenard)
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.