1142040 - CodeGen.py generates a code which could be simplified

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

Discovered by coverity, 
In the generated file HTMLAllCollectionBinding.cpp, line 958 we have:

deleteSucceeded = !found;
if (found) {
      return deleteSucceeded ? opresult.succeed() : opresult.failCantDelete();
}

The operation opresult.succeed() won't be executed.

That is no big deal at all but we could improve that in order to simplify the generated code.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Maybe a good first bug?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Maaaybe.  The problem is that simplifying this involves making the code generator more complex: the place where deleteSucceeded is assigned is quite far away from the place where it's used in code generator terms.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I am now ignoring them (by hand) in coverity.