1142063 - Condition for mozharness factory needs enable_periodic

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Michael Shal [:mshal]]

I don't really understand the conditions used to determine which factory to create, but I'm told that we need to change the condition around makeMHFactory:

if pf.get('enable_dep', True):

to include a check for 'enable_periodic', so it matches some logic later in misc.py. Ie, it should be this:

# Some platforms shouldn't do dep builds (i.e. RPM)
if pf.get('enable_dep', True) or pf.get('enable_periodic', False):

Comment 1

[Michael Shal [:mshal]]

Attachment: bb-enable-periodic.patch

This allows me to build win32_gecko with mozharness, whereas before I could not.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8576006 [details] [diff] [review]
bb-enable-periodic.patch

https://hg.mozilla.org/build/buildbotcustom/rev/797716224ab8

Comment 3

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/797716224ab8