1142108 - Make TestUtils.topicObserved cover more use cases

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[:Paolo Amadini]

Attachment: The patch

Sometimes the subject of an observer notification is the interesting result when a topic is observed, while sometimes the data string is. The TestUtils.topicObserved API can be made more flexible by using a callback to determine if the notification is relevant, and resolving with the subject and data.

For example, for checking that a login is added to the database:


let promiseLogin = TestUtils.topicObserved("passwordmgr-storage-changed",
                                           (_, data) => data == "addLogin");
let [login] = yield promiseLogin;


In this patch I've also fixed an unterminated promise chain.

Comment 1

[Steven MacLeod [:smacleod]]

Comment on attachment 8576058 [details] [diff] [review]
The patch

Review of attachment 8576058 [details] [diff] [review]:
-----------------------------------------------------------------

oo, I like this change a lot :D

Comment 2

[:Paolo Amadini]

Thanks for the quick review! Will land when the tree reopens.

Comment 3

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/d1ffaeb0dbfd

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1ffaeb0dbfd