1142181 - ProfilerBacktrace.cpp should #include its own .h file first

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

As noted in bug 1129249 comment 38, ProfilerBacktrace.h currently is missing a forward-decl for "JSStreamWriter".

We should make ProfilerBacktrace.h be the first #include in its .cpp file (as is convention in gecko), to catch issues like this proactively.

Comment 1

[Daniel Holbert [:dholbert]]

(Right now ProfilerBacktrace.cpp has:

> #include "JSStreamWriter.h"
> #include "ProfilerBacktrace.h"
> #include "SyncProfile.h"

which masks the missing forward-decl, because it sees the JSStreamWriter class-definition before it sees its .h file with the missing forward decl. If we put the "ProfilerBacktrace.h" include first, then we would've hit this error when compiling ProfilerBacktrace.cpp and caught it sooner.)

Comment 2

[Chiajung Hung [:chiajung]]

Attachment: v1

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8576456 [details] [diff] [review]
v1

Review of attachment 8576456 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/ProfilerBacktrace.cpp
@@ +7,1 @@
>  #include "ProfilerBacktrace.h"

Please add a blank line between the ProfilerBacktrace.h and the JSStreamWriter.h includes.

Comment 4

[Chiajung Hung [:chiajung]]

Attachment: v1 final

Comment addressed

Comment 5

[Chiajung Hung [:chiajung]]

Attachment: v1 final(add r=)

Add reviewer info, 
Try ticket:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=649ee64c216c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56f421903a91

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/56f421903a91