1142260 - Re-sort prefs in gfxPrefs.h

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The prefs in gfx/thebes/gfxPrefs.h are supposed to be in alphabetical order. Somebody should re-sort them, and add a big scary warning at the *bottom* of the list telling people not to add them blindly to the bottom.

Comment 1

[pinjiz]

Attachment: fix_alphabetical_order.patch

This is my first Mozilla Firefox bug fix. I've re-sorted the prefs and added a warning at the bottom of the list.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8581120 [details] [diff] [review]
fix_alphabetical_order.patch

Review of attachment 8581120 [details] [diff] [review]:
-----------------------------------------------------------------

That's perfect, thanks! I'll land the patch into our tree.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e177495aa9

Once this gets to merged to the mozilla-central tree (usually happens once a day or so) this bug will be marked fixed. Thanks a lot for the patch! If you would like help finding another bug to work on please do let me know, I'd be happy to help.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a6e177495aa9