Closed Bug 1142260 Opened 5 years ago Closed 5 years ago

Re-sort prefs in gfxPrefs.h

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: kats, Assigned: jannis, Mentored)

Details

(Whiteboard: [good first bug][lang=c++][gfx-noted])

Attachments

(1 file)

The prefs in gfx/thebes/gfxPrefs.h are supposed to be in alphabetical order. Somebody should re-sort them, and add a big scary warning at the *bottom* of the list telling people not to add them blindly to the bottom.
Whiteboard: [good first bug][lang=c++]
Mentor: bugmail.mozilla
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][gfx-noted]
This is my first Mozilla Firefox bug fix. I've re-sorted the prefs and added a warning at the bottom of the list.
Attachment #8581120 - Flags: review?(bugmail.mozilla)
Comment on attachment 8581120 [details] [diff] [review]
fix_alphabetical_order.patch

Review of attachment 8581120 [details] [diff] [review]:
-----------------------------------------------------------------

That's perfect, thanks! I'll land the patch into our tree.
Attachment #8581120 - Flags: review?(bugmail.mozilla) → review+
Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e177495aa9

Once this gets to merged to the mozilla-central tree (usually happens once a day or so) this bug will be marked fixed. Thanks a lot for the patch! If you would like help finding another bug to work on please do let me know, I'd be happy to help.
Assignee: nobody → jannis
https://hg.mozilla.org/mozilla-central/rev/a6e177495aa9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.