Closed Bug 1142268 Opened 8 years ago Closed 8 years ago

Tweak layout size for doorhanger shadow

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: liuche, Assigned: jannis, Mentored)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 file)

tweak_doorhanger_shadow_size.patch
1.53 KB, patch
liuche
: review+
Details | Diff | Splinter Review 
The shadow in anchor_popup.xml should have 1dp extra padding the bottom.
This patch adds 1dp extra to the bottom of the doorhanger shadow and leaves the shadow size of the other sides (left, top, right) unchanged.
Attachment #8581282 - Flags: review?(liuche)
Comment on attachment 8581282 [details] [diff] [review]
tweak_doorhanger_shadow_size.patch

Review of attachment 8581282 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks, Jannis, sorry it took me a few days to get back to this.
Attachment #8581282 - Flags: review?(liuche) → review+
https://hg.mozilla.org/integration/fx-team/rev/02974be498e5
Target Milestone: --- → Firefox 39
https://hg.mozilla.org/mozilla-central/rev/02974be498e5
Assignee: nobody → jannis
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.