Closed
Bug 1142268
Opened 10 years ago
Closed 10 years ago
Tweak layout size for doorhanger shadow
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: liuche, Assigned: jannis, Mentored)
Details
(Whiteboard: [good first bug][lang=java])
Attachments
(1 file)
|
1.53 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
The shadow in anchor_popup.xml should have 1dp extra padding the bottom.
This patch adds 1dp extra to the bottom of the doorhanger shadow and leaves the shadow size of the other sides (left, top, right) unchanged.
Attachment #8581282 -
Flags: review?(liuche)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8581282 [details] [diff] [review]
tweak_doorhanger_shadow_size.patch
Review of attachment 8581282 [details] [diff] [review]:
-----------------------------------------------------------------
Great! Thanks, Jannis, sorry it took me a few days to get back to this.
Attachment #8581282 -
Flags: review?(liuche) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
Target Milestone: --- → Firefox 39
Assignee: nobody → jannis
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•