Tweak layout size for doorhanger shadow

RESOLVED FIXED in Firefox 39

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: liuche, Assigned: jannis, Mentored)

Tracking

Trunk
Firefox 39
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [good first bug][lang=java])

Attachments

(1 attachment)

Reporter

Description

4 years ago
The shadow in anchor_popup.xml should have 1dp extra padding the bottom.
Assignee

Comment 1

4 years ago
This patch adds 1dp extra to the bottom of the doorhanger shadow and leaves the shadow size of the other sides (left, top, right) unchanged.
Attachment #8581282 - Flags: review?(liuche)
Reporter

Comment 2

4 years ago
Comment on attachment 8581282 [details] [diff] [review]
tweak_doorhanger_shadow_size.patch

Review of attachment 8581282 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks, Jannis, sorry it took me a few days to get back to this.
Attachment #8581282 - Flags: review?(liuche) → review+
Reporter

Comment 3

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/02974be498e5
Target Milestone: --- → Firefox 39
https://hg.mozilla.org/mozilla-central/rev/02974be498e5
Assignee: nobody → jannis
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.