1142310 - Stop parenting scripted functions to non-globals

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is already done for native functions, just scripted ones left.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop parenting scripted functions created via the NewFunction APIs to non-globals

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Stop parenting scripted functions created via CloneFunctionObject to non-globals

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jeff, I basically ignored the silly framescript setup and parented everything to globals anyway.  Hope that's ok.

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 8577371 [details] [diff] [review]
part 1.  Stop parenting scripted functions created via the NewFunction APIs to non-globals

Review of attachment 8577371 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfun.h
@@ +515,5 @@
>                       NewObjectKind newKind = GenericObject,
>                       JSFunction::Flags flags = JSFunction::NATIVE_CTOR);
>  
>  // Allocate a new scripted function.  If null is passed for
> +// enclosingDynamicScope, the global will be used.  In all cases the parent of

"If enclosingDynamicScope is null" probably wraps better, more readable.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> "If enclosingDynamicScope is null" probably wraps better, more readable.

Done.

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67298a640395
https://hg.mozilla.org/integration/mozilla-inbound/rev/91b3f8e902a6

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/67298a640395
https://hg.mozilla.org/mozilla-central/rev/91b3f8e902a6