1142459 - Mixed Content Blocking shield icon is not displayed in URL Bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open https://ie.microsoft.com/testdrive/browser/mixedcontent/assets/woodgrove.htm
2. Choose "I Understand the Risks" -> "Visit Site" option

Expected results:
- Page is loaded with the shield icon displayed in the URL bar

Actual results:
- The shield icon is missing from the URL bar

Note:
- recent regression:
good build: 10-03
bad build: 11-03
pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6686aacf006f&tochange=fd8e079d6335

Bug 1140830 - HTC One M8 (Verizon) users reporting startup crashes after Lollipop (Android 5.0.1) update ?

Comment 1

[Aaron Train [:aaronmt]]

regression from bug 1140830

Comment 2

[Richard Newman [:rnewman]]

This should be a very small fix. snorp nodded on IRC, so over it goes.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix mixed content shield notification broke by bug 1140830

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix mixed content shield notification broke by bug 1140830

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8576873 [details] [diff] [review]
Fix mixed content shield notification broke by bug 1140830

Review of attachment 8576873 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/SiteIdentity.java
@@ +176,3 @@
>              }
>          } catch (Exception e) {
> +            resetIdentity();

This should be reset(), no?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Richard Newman [:rnewman] from comment #5)
> Comment on attachment 8576873 [details] [diff] [review]
> Fix mixed content shield notification broke by bug 1140830
> 
> Review of attachment 8576873 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/SiteIdentity.java
> @@ +176,3 @@
> >              }
> >          } catch (Exception e) {
> > +            resetIdentity();
> 
> This should be reset(), no?

Ugh, indeed.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Fix mixed content shield notification broke by bug 1140830

Comment 8

[Richard Newman [:rnewman]]

Comment on attachment 8576885 [details] [diff] [review]
Fix mixed content shield notification broke by bug 1140830

Review of attachment 8576885 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Test it! :D

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8576885 [details] [diff] [review]
Fix mixed content shield notification broke by bug 1140830

Approval Request Comment
[Feature/regressing bug #]: bug 1140830
[User impact if declined]: no mixed mode icon
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c9a8a1e12b7

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Bug 1140830 landed on 36-39. This fix will be needed on all branches.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b31df8fa73a5

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7c51bb7366b3

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/05208c58686f

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1c9a8a1e12b7

Comment 16

[u421692]

Verified as fixed on ZTE Grand X In (Android 4.0.4) and Nexus 7 (Android 5.0.2) on Firefox 36.0.2 Build2, on latest Aurora and latest Nightly.

Comment 17

[Flaviu Cos]

Verified as fixed in build 37 beta 6;
Device: Lenovo Yoga Tab 10 (Android 4.4.2).