1142491 - Provide a page with third-party library attribution

Status: RESOLVED WONTFIX

(Firefox for iOS :: Build & Test, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

We use a bunch of third-party (open source) libraries. Some of these require proper attribution in the project. Most apps have a simple 'Credits' link somewhere that lists the names of the projects.

Maybe we can have this in the Settings?

Comment 1

[alessio.brozzi]

Hi, I'd like to take up this bug!

I have a general idea of how to implement the request, however, do you have any specifications or pointers that I should consider?

Comment 2

[alessio.brozzi]

Attachment: Pull Request

Comment 3

[Emily Toop (:fluffyemily)]

Comment on attachment 8847180 [details] [review]
Pull Request

Please can you remove all the unnecessary changes to the project file? Then, we will probably use this branch as a base, put a feature flag around it and get our UX people to look a the language & visuals of the `thirdparty.html` before enabling this in shipping code. 

Thanks for this. It's a great start.

Comment 4

[alessio.brozzi]

(In reply to Emily Toop (:fluffyemily) from comment #3)
> Comment on attachment 8847180 [details] [review]
> Pull Request
> 
> Please can you remove all the unnecessary changes to the project file? Then,
> we will probably use this branch as a base, put a feature flag around it and
> get our UX people to look a the language & visuals of the `thirdparty.html`
> before enabling this in shipping code. 
> 
> Thanks for this. It's a great start.

I implemented the requested changes. I looked up on how to add a feature flag around my changes and tried following this guide (https://github.com/mozilla-mobile/firefox-ios/wiki/Adding-a-Feature-Flag), however I can't seem to locate the specified file FeatureFlags.xcconfig in the project. Should I follow another guide?

Thanks

Comment 5

[Josh Matthews [:jdm]]

See comment 4.

Comment 6

[alessio.brozzi]

Hi Emily, just wondering if I should contact the Mozilla UX team to take a look at thirdparty.html... 
Moreover, I added a sample paragraph to thirdparty.html of third-party attribution for one of the libraries Firefox uses.

Comment 7

[Emily Toop (:fluffyemily)]

assigning this to :sleroux to pick up.

Comment 8

[Farhan Patel [:farhan]]

We already have a license page that covers this use case.
https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Assets/About/Licenses.html


Closing this.

Comment 9

[alessio.brozzi]

Hi Farhan,
It’s true that the License page contains third-party attribution, however it’s good practice to have a separate page for third-party attributions since they’re more accessible this way and this is how the most popular apps on the App Store do (Google Chrome/Maps, Amazon, Youtube, Spotify, Facebook etc.. See attached in the pull request: https://github.com/mozilla-mobile/firefox-ios/pull/2521).
This is just some info in case you might consider reopening the bug.