Closed Bug 1142495 Opened 7 years ago Closed 7 years ago

ICC build error on emulator L

Categories

(Firefox OS Graveyard :: RIL, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox39 fixed)

RESOLVED FIXED
2.2 S8 (20mar)
Tracking Status
firefox39 --- fixed

People

(Reporter: tzimmermann, Assigned: edgar)

References

Details

Attachments

(1 file)

Hi Hsinyi, Edgar,

we're close to enabling emulator L builds. Can you take a look? Looks like a trivial build issue in the RIL stack.
Flags: needinfo?(htsai)
Flags: needinfo?(echen)
Summary: IICC build error on emulator L → ICC build error on emulator L
Emulator L jobs can be run on Try using the |try: -b do -p emulator-l -u none -t none| syntax. They're hidden by default, so you'll need to click the "Show/hide hidden jobs" toggle on Treeherder (or just add &exclusion_profile=false to the URL in the location bar).
Looks like same as https://bugzilla.mozilla.org/show_bug.cgi?id=1114935#c42. I will take a look.
Assignee: nobody → echen
Flags: needinfo?(htsai)
Flags: needinfo?(echen)
Attached patch Patch, v1Splinter Review
Comment on attachment 8576716 [details] [diff] [review]
Patch, v1

Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Edgar Chen [:edgar][:echen] (OOO 3/21~4/6) from comment #5)
> Try:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=0c1fa9beec0f&exclusion_profile=false

Emulator-l debug build is green with applying this patch. 
Hi Hsinyi, would you mind reviewing this patch?

Thank you.
Attachment #8576716 - Flags: review?(htsai)
Comment on attachment 8576716 [details] [diff] [review]
Patch, v1

Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, yes  Orz
Attachment #8576716 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/937916041915
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in before you can comment on or make changes to this bug.