1142495 - ICC build error on emulator L

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Debug builds on emulator l fail with a build error in the RIL code. The log is at [1].

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&exclusion_profile=false&filter-searchStr=b2g_mozilla-central_emulator-l

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Hsinyi, Edgar,

we're close to enabling emulator L builds. Can you take a look? Looks like a trivial build issue in the RIL stack.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Emulator L jobs can be run on Try using the |try: -b do -p emulator-l -u none -t none| syntax. They're hidden by default, so you'll need to click the "Show/hide hidden jobs" toggle on Treeherder (or just add &exclusion_profile=false to the URL in the location bar).

Comment 3

[Edgar Chen [:edgar]]

Looks like same as https://bugzilla.mozilla.org/show_bug.cgi?id=1114935#c42. I will take a look.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 5

[Edgar Chen [:edgar]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c1fa9beec0f&exclusion_profile=false

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8576716 [details] [diff] [review]
Patch, v1

Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Edgar Chen [:edgar][:echen] (OOO 3/21~4/6) from comment #5)
> Try:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=0c1fa9beec0f&exclusion_profile=false

Emulator-l debug build is green with applying this patch. 
Hi Hsinyi, would you mind reviewing this patch?

Thank you.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8576716 [details] [diff] [review]
Patch, v1

Review of attachment 8576716 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, yes  Orz

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/937916041915

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/937916041915