Closed Bug 1142520 Opened 5 years ago Closed 4 years ago

Add telemetry for context in conversations

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox41 fixed, firefox42 fixed)

RESOLVED FIXED
mozilla42
Iteration:
42.1 - Jul 13
Tracking Status
firefox41 --- fixed
firefox42 --- fixed

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

(Whiteboard: [context][metrics][uplift to fx40])

User Story

Telemetry events should be sent when:
* Conversations are created with context
* Context URLs are accessed from the conversation window
* Context is added from within the conversation window

This is opt-out.

Attachments

(1 file, 1 obsolete file)

There's several of the user stories requiring telemetry, I think it makes sense to do them all in one bug.
Rank: 25
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [context][metrics]
Rank: 25 → 19
Priority: P2 → P1
Whiteboard: [context][metrics] → [context][metrics][uplift to fx39]
This bug is required for delivery together with the context sharing feature in Fx39.
This *could* be done together with bug 1127574 and bug 1129726 which are both also telemetry related.
Added a line on the US field to clarify this is opt-out.
User Story: (updated)
Blocks: 1115340
User Story: (updated)
Assignee: nobody → mdeboer
Iteration: --- → 41.2 - Jun 8
Whiteboard: [context][metrics][uplift to fx39] → [context][metrics][uplift to fx40]
Points: --- → 2
Attachment #8613499 - Flags: review?(vdjeric)
Attachment #8613499 - Flags: review?(standard8)
Status: NEW → ASSIGNED
Flags: qe-verify-
Comment on attachment 8613499 [details] [diff] [review]
Patch v1: add telemetry hooks for context add and URL access actions

Review of attachment 8613499 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +7543,5 @@
>      "description": "Number of times a room action is performed (0=CREATE_SUCCESS, 1=CREATE_FAIL, 2=DELETE_SUCCESS, 3=DELETE_FAIL)"
>    },
> +  "LOOP_ROOM_CONTEXT_ACTIONS": {
> +    "alert_emails": ["firefox-dev@mozilla.org", "mdeboer@mozilla.com"],
> +    "expires_in_version": "50",

same concerns here as bug 1127574: 1 year of opt-out data collection seems excessive + how is this data going to be interpreted (which questions does it answer)
Attachment #8613499 - Flags: review?(vdjeric)
Comment on attachment 8613499 [details] [diff] [review]
Patch v1: add telemetry hooks for context add and URL access actions

Review of attachment 8613499 [details] [diff] [review]:
-----------------------------------------------------------------

r+ subject to the opt-out review.

::: browser/components/loop/modules/MozLoopAPI.jsm
@@ +674,5 @@
>        get: function() {
>          return Cu.cloneInto(ROOM_ACTIONS, targetWindow);
>        }
>      },
> +    

nit: whitespace on blank line.
Attachment #8613499 - Flags: review?(standard8) → review+
Carrying over r=Standard8.
Attachment #8613499 - Attachment is obsolete: true
Attachment #8615389 - Flags: review?(vdjeric)
Comment on attachment 8615389 [details] [diff] [review]
Patch v2: add telemetry hooks for context add and URL access actions

Review of attachment 8615389 [details] [diff] [review]:
-----------------------------------------------------------------

Postponing review until we figure out approach over email
Attachment #8615389 - Flags: review?(vdjeric)
Attachment #8615389 - Flags: review?(vdjeric)
Attachment #8615389 - Flags: review?(vdjeric)
Iteration: 41.2 - Jun 8 → 41.3 - Jun 29
Attachment #8615389 - Flags: review?(vdjeric)
I'll take a look tomorrow, I'm on PTO today
Iteration: 41.3 - Jun 29 → 42.1 - Jul 13
Comment on attachment 8615389 [details] [diff] [review]
Patch v2: add telemetry hooks for context add and URL access actions

Review of attachment 8615389 [details] [diff] [review]:
-----------------------------------------------------------------

somehow I had missed this review request yesterday :(

r+ for Histograms.json probes
Attachment #8615389 - Flags: review?(vdjeric) → review+
https://hg.mozilla.org/mozilla-central/rev/fadd9de382cb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment on attachment 8615389 [details] [diff] [review]
Patch v2: add telemetry hooks for context add and URL access actions

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello, no bug.
[User impact if declined]: Hello context in conversations have been introduced in Fx 40, but we weren't measuring their usage from the client.
For our product owner it's important to _know_ during this phase of the product.
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.
Attachment #8615389 - Flags: approval-mozilla-aurora?
Comment on attachment 8615389 [details] [diff] [review]
Patch v2: add telemetry hooks for context add and URL access actions

Approving for Aurora uplift because minor risks, has been on m-c with no known issues, tests pass.
Attachment #8615389 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.