1142540 - [Messages][Refactoring] Use Promise as return result for public contacts.js methods

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

After bug 839838 DOMRequest has Promise-based "then()" method. So we can use "navigation.mozContacts.find()" return result as Promise and migrate all public callback-based methods from contacts.js to promises.

It should simplify the code base, especially some places where contacts.js consumers use "Utils.Promise.defer()" to simulate Promise-based interface.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Will try to do this refactoring before we start fixing recipients-related bugs - hope this will make it easier.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1142540-refactor-contacts > mozilla-b2g:master

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1142540-contact-promises > mozilla-b2g:master

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8585333 [details] [review]
[gaia] julienw:1142540-contact-promises > mozilla-b2g:master

Hey Oleg,

you're likely the best to review this because you also looked at this issue previously :)

I tested on device various situations and I could not make it break.

Tell me what you think !

Comment 5

[Julien Wajsberg [:julienw]]

OK Oleg, I think it's ready for a second review. I've put all changes in a separate commit !

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8585333 [details] [review]
[gaia] julienw:1142540-contact-promises > mozilla-b2g:master

Looks good now! Just fix one typo and nit in unit test before landing.

Thanks!

Comment 7

[Julien Wajsberg [:julienw]]

Fixed comments and rebased and pushed !

Comment 8

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#PVX9vDT3SuavQpI5CiVQ3g

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 9

[Julien Wajsberg [:julienw]]

Unrelated issue, landing:

master: 43f67fb074c326286bdb15b31749b0905d427558