1142579 - Don't try to show multiple log viewer icons for a job

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Ed Morley [:emorley]]

A job can have multiple log URLs associated with it.

Now it makes sense to display a "view raw log" icon for each, however the log viewer doesn't use the log URL and instead uses the text_log_summary artefact.

The tl;dr is that the log viewer block here:
https://github.com/mozilla/treeherder-ui/blob/79fb7a67901ba262ab9c12dd02e1b4dbccced89d/webapp/app/plugins/pluginpanel.html#L18

...should not be in a |job_log_url in job_log_urls| and instead see if we have a 'text_log_summary' artefact.

Along similar lines, the logic here is also flawed:

https://github.com/mozilla/treeherder-ui/blob/b9a4d69dc529e119600e559827a9c90533c67ce0/webapp/app/js/controllers/jobs.js#L131

Notably:

> data.artifacts.forEach(function(artifact) {
>     if (artifact.name === "text_log_summary") {
>         window.open(thUrl.getLogViewerUrl(artifact.id));
>     }
> });

Whilst that looks great in principal - "artifact.id" is really "job_id" and it's going to be the same for each artefact - so getLogViewerUrl() is going to open multiple duplicate tabs, when it should just open one.

Comment 1

[Albiona]

Hi, I am an outreachy applicant, I would like to work on this task.

Comment 2

[Sarah Clements [:sclements]]

Hi Albiona, I think this one has already been claimed. Sabina were you wanting this bug assigned to you?

Comment 3

[Sabina Barbhuiya]

Yes :)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5441

Comment 6

[Cameron Dawson [:camd]]

Please see the "see also" and "duplicate" bug 1113264 for more info on this.

Comment 7

[Sabina Barbhuiya]

Just saw the duplicate bug with your comments in it. Very useful!

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5475