Closed Bug 1142699 Opened 10 years ago Closed 10 years ago

Intermittent testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 60000

Categories

(Firefox for Android Graveyard :: Testing, defect)

Product:
Firefox for Android Graveyard
Component:
Testing
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox37 unaffected, firefox38 unaffected, firefox39 fixed, firefox-esr31 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox37 --- unaffected
firefox38 --- unaffected
firefox39 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: sebastian)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

1142699_testReaderModeTitle_geckoWait_v2.patch
2.41 KB, patch
mcomella
: review+
Details | Diff | Splinter Review
12:58:35 INFO - SimpleTest START 12:58:35 INFO - TEST-START | testReaderModeTitle 12:58:35 INFO - TEST-PASS | testReaderModeTitle | Robocop tests need the test device screen to be powered on. - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | url is not null - /robocop/reader_mode_pages/basic_article.html should not equal null 12:58:35 INFO - TEST-PASS | testReaderModeTitle | url is not null - /robocop/reader_mode_pages/basic_article.html should not equal null 12:58:35 INFO - TEST-PASS | testReaderModeTitle | The toolbar is not in the editing state - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | Waiting for Toolbar to enter editing mode. - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | Waiting for UrlEditText to be input method target. - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | url is not null - http://mochi.test:8888/tests/robocop/reader_mode_pages/basic_article.html should not equal null 12:58:35 INFO - TEST-PASS | testReaderModeTitle | The toolbar is in the editing state - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | The UrlEditText is the input method target - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | The toolbar is in the editing state - 12:58:35 INFO - TEST-PASS | testReaderModeTitle | initiatingAction is not null - org.mozilla.gecko.tests.components.ToolbarComponent$2@4060b838 should not equal null 12:58:35 INFO - ToolbarTitleTextChangeVerifier: stored title, "". 12:58:35 INFO - EventExpecter: no longer listening for DOMContentLoaded 12:58:35 INFO - EventExpecter: no longer listening for DOMTitleChanged 12:58:35 INFO - ToolbarTitleTextChangeVerifier: state changed to title, "mochi.test:8888/tests/robocop/reader_mode_pages/basic_article.html". 12:58:35 INFO - ToolbarTitleTextChangeVerifier: was satisfied. 12:58:35 INFO - TEST-PASS | testReaderModeTitle | Waiting for Toolbar to exit editing mode. - 12:58:35 WARNING - TEST-UNEXPECTED-FAIL | testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 30000. - 12:58:35 INFO - 0 ERROR Exception caught during test! - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 30000. - 12:58:35 INFO - at junit.framework.Assert.fail(Assert.java:47) 12:58:35 INFO - at org.mozilla.gecko.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:128) 12:58:35 INFO - at org.mozilla.gecko.FennecMochitestAssert.ok(FennecMochitestAssert.java:150) 12:58:35 INFO - at org.mozilla.gecko.tests.helpers.AssertionHelper.fAssertTrue(AssertionHelper.java:98) 12:58:35 INFO - at org.mozilla.gecko.tests.helpers.WaitHelper.waitFor(WaitHelper.java:70) 12:58:35 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.waitForReaderModeButton(ToolbarComponent.java:296) 12:58:35 INFO - at org.mozilla.gecko.tests.components.ToolbarComponent.pressReaderModeButton(ToolbarComponent.java:252) 12:58:35 INFO - at org.mozilla.gecko.tests.testReaderModeTitle.testReaderModeTitle(testReaderModeTitle.java:12) 12:58:35 INFO - at java.lang.reflect.Method.invokeNative(Native Method) 12:58:35 INFO - at java.lang.reflect.Method.invoke(Method.java:507) 12:58:35 INFO - at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204) 12:58:35 INFO - at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194) 12:58:35 INFO - at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186) 12:58:35 INFO - at org.mozilla.gecko.tests.UITest.runTest(UITest.java:77) 12:58:35 INFO - at junit.framework.TestCase.runBare(TestCase.java:127) 12:58:35 INFO - at junit.framework.TestResult$1.protect(TestResult.java:106) 12:58:35 INFO - at junit.framework.TestResult.runProtected(TestResult.java:124) 12:58:35 INFO - at junit.framework.TestResult.run(TestResult.java:109) 12:58:35 INFO - at junit.framework.TestCase.run(TestCase.java:118) 12:58:35 INFO - at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169) 12:58:35 INFO - at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154) 12:58:35 INFO - at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:529) 12:58:35 INFO - at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1448) 12:58:35 INFO - 12:58:35 WARNING - TEST-UNEXPECTED-FAIL | testReaderModeTitle | Exception caught - junit.framework.AssertionFailedError: TEST-UNEXPECTED-FAIL | testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 30000. - 12:58:35 INFO - TEST-OK | testReaderModeTitle | took 130327ms 12:58:35 INFO - TEST-START | Shutdown 12:58:35 INFO - Passed: 12 12:58:35 INFO - Failed: 2 12:58:35 INFO - Todo: 0 12:58:35 INFO - SimpleTest FINISHED
Well, shucks. Sebastian, can you look into this?
Assignee: nobody → s.kaspari
Flags: needinfo?(s.kaspari)
(In reply to Michael Comella (:mcomella) from comment #3) > Well, shucks. > > Sebastian, can you look into this? Sure!
Flags: needinfo?(s.kaspari)
Status: NEW → ASSIGNED
The test only failed (sometimes) on API 9 / Android 2.3 emulators. I did a couple of try runs[1] with my new super powers but they all passed. It seems like sometimes the emulators are super slow and the waiting time is not enough. I'd like to raise the waiting time for this case and see if the problem vanishes. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=219726640687
Attachment #8577598 - Flags: review?(michael.l.comella)
Comment on attachment 8577598 [details] [diff] [review] 1142699_toolbarcomponent_waittime.patch Review of attachment 8577598 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tests/components/ToolbarComponent.java @@ +37,2 @@ > // because reader mode parsing can take quite some time on slower devices > + // See Bug 1142699 Typically style is: // (Bug ###) blah blah blah... OR // ...blah blah blah (bug ###) But no reason to waste time fixing this so wfm.
Attachment #8577598 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/integration/fx-team/rev/382875ef67af
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/382875ef67af
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Status: RESOLVED → REOPENED
status-firefox39: fixed → affected
Resolution: FIXED → ---
Summary: Intermittent testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 30000 → Intermittent testReaderModeTitle | Waiting for the Reader mode button to be visible with timeout 60000
Target Milestone: Firefox 39 → ---
The log in comment 36 looks like we don't actually load the page: 12:28:56 INFO - ToolbarTitleTextChangeVerifier: stored title, "". ... 12:28:56 INFO - ToolbarTitleTextChangeVerifier: timed out. 12:28:56 INFO - TEST-PASS | testReaderModeTitle | Waiting for Toolbar to exit editing mode. - Are there any other tests that use basic_article? I wonder if we're mangling something here.
Also, the screenshot in the logs displays about:home. Ah, perhaps Gecko isn't started yet so we can't load the page. Perhaps we need to wait for Gecko:Ready? See `GeckoHelper.blockForReady();` - most UITests start with this. Sorry that I missed this earlier! Also, I'd try lowering the wait time to 30000.
(In reply to Michael Comella (:mcomella) from comment #38) > Ah, perhaps Gecko isn't started yet so we can't load the page. Perhaps we > need to wait for Gecko:Ready? See `GeckoHelper.blockForReady();` - most > UITests start with this. Sorry that I missed this earlier! Oh yeah, this makes so much sense. Thank you for helping me debugging this. I'll create a new patch.
Attachment #8577598 - Attachment is obsolete: true
Attachment #8580329 - Flags: review?(michael.l.comella)
Attachment #8580329 - Attachment is obsolete: true
Attachment #8580329 - Flags: review?(michael.l.comella)
Attachment #8580332 - Flags: review?(michael.l.comella)
Comment on attachment 8580332 [details] [diff] [review] 1142699_testReaderModeTitle_geckoWait_v2.patch Review of attachment 8580332 [details] [diff] [review]: ----------------------------------------------------------------- lgtm! Note: Gecko:Ready indicates the point at which Gecko can first load pages; there is also Gecko:DelayedStartup which fires slightly later so that Gecko's background loading doesn't interfere with input processing (e.g. in testAboutHomePageNavigation, we would drop swipes on our HomePanel because Android couldn't smoothly process the user input and load Gecko things in the background, so we waited for DelayedStartup instead). We avoid doing this on every test because it can take a long time to start.
Attachment #8580332 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/013423d74788
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
status-firefox39: affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: