Closed
Bug 1142768
Opened 10 years ago
Closed 9 years ago
Service Worker client.url should use "creation url"
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: catalinb, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.74 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
spec change for creation url: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27146
Service worker client spec reference: http://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#client-url
|
||
Comment 1•10 years ago
|
||
Hey Catalin, would you mentor here please? Thanks!
|
|
||
Updated•10 years ago
|
Flags: needinfo?(catalin.badea392)
|
Reporter | |
Comment 2•10 years ago
|
||
I'd wait for the w3c bug to be finished before moving forward with this. It doesn't look like this issue got too much attention lately.
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27146
Flags: needinfo?(catalin.badea392)
|
||
Updated•9 years ago
|
|
||
Updated•9 years ago
|
Blocks: ServiceWorkers-compat
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ehsan
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8705311 -
Flags: review?(bkelly)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8705311 [details] [diff] [review]
Return the original document URI from ServiceWorkerClient.url
Review of attachment 8705311 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks!
::: dom/workers/ServiceWorkerClient.cpp
@@ +49,5 @@
> + nsCOMPtr<nsIURI> originalURI = aDoc->GetOriginalURI();
> + if (originalURI) {
> + nsAutoCString spec;
> + originalURI->GetSpec(spec);
> + mUrl.Assign(NS_ConvertUTF8toUTF16(spec));
Can you just use CopyUTF8toUTF16() here?
::: testing/web-platform/mozilla/tests/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html
@@ +1,3 @@
> <!DOCTYPE html>
> <title>Empty doc</title>
> +<body onload="history.pushState({}, 'title', 'new-url.html')">
Maybe add a comment here to indicate what this is for. Out of context of this bug I know it would confuse me.
Attachment #8705311 -
Flags: review?(bkelly) → review+
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•