Closed Bug 1142988 Opened 9 years ago Closed 8 years ago

Flash crashes on Nexus 9

Categories

(Firefox for Android Graveyard :: Plugins, defect)

Product:
Firefox for Android Graveyard
Component:
Plugins
Version:
34 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 affected, firefox46 verified, firefox47 verified, firefox48 verified, fennec47+)

Status:
VERIFIED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox45 --- affected
firefox46 --- verified
firefox47 --- verified
firefox48 --- verified
fennec 47+ ---

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

Try harder to disable Flash on Tegra devices
1.47 KB, patch
droeh
: review+
lizzard
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Presumably this is because the Nexus 9 has a 64-bit user land, and the 32-bit Flash plugin links to some of these. We should probably just block Flash on 64-bit.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0)
> Presumably this is because the Nexus 9 has a 64-bit user land, and the
> 32-bit Flash plugin links to some of these. We should probably just block
> Flash on 64-bit.

That sounds right to me
Actually we are able to load/link the plugin, it just crashes during init somewhere. JimDB is busted on 64-bit, so I don't know exactly where yet. Flash works in Dolphin on this device, so presumably we can make it work.
tracking-fennec: --- → 47+
We should just block Flash on the Nexus 9
Assignee: nobody → snorp
Comment on attachment 8726248 [details] [diff] [review]
Try harder to disable Flash on Tegra devices

Review of attachment 8726248 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me provided that the previous checks are not made redundant by the new one.
Attachment #8726248 - Flags: review?(droeh) → review+
https://hg.mozilla.org/mozilla-central/rev/4beeb84a6696
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
I am this gonna be uplifted? I am easily reproducing it on Nexus 9 (Android 6.0.1) by playing a video on cnn.com

Verified as fixed for Nightly.
status-firefox45: --- → affected
status-firefox46: --- → affected
status-firefox47: --- → affected
status-firefox48: fixed → verified
Comment on attachment 8726248 [details] [diff] [review]
Try harder to disable Flash on Tegra devices

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: Crashes when using Flash on Nexus 9
[Describe test coverage new/current, TreeHerder]: Nightly, Aurora
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8726248 - Flags: approval-mozilla-beta?
Attachment #8726248 - Flags: approval-mozilla-aurora?
Comment on attachment 8726248 [details] [diff] [review]
Try harder to disable Flash on Tegra devices

Crash fix for android, let's land this in beta.
Attachment #8726248 - Flags: approval-mozilla-beta?
Attachment #8726248 - Flags: approval-mozilla-beta+
Attachment #8726248 - Flags: approval-mozilla-aurora?
Attachment #8726248 - Flags: approval-mozilla-aurora+
Verified this with the steps mentioned in comment 9:  go to cnn.com and start a video. 
Working on both Aurora 47 (03/29) and 46 Beta 6 on Nexus 9 (Android 6.0.1)
Status: RESOLVED → VERIFIED
status-firefox46: fixed → verified
status-firefox47: fixed → verified
See Also: → 1272810
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: