Hide Reading List icon from overflow menu if reading list is hidden from homescreen

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: pwd.mozilla, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150312145801

Steps to reproduce:

If the reading list is hidden via the homescreen customisation panel, we should assume that the user wants to disable it. Thus we should hide the icon in the overflow menu. Would be awesome to hide it in the location bar too.
These special case conditions are getting complex.

Comment 2

4 years ago
I don't think we need to support this. Currently, you can hide your bookmark panel, but we don't disable the bookmark start. And even if you have the reading list panel hidden, you may want to add something to your reading list to read later on desktop.
(Reporter)

Comment 3

4 years ago
(In reply to Aaron Train [:aaronmt] from comment #1)
> These special case conditions are getting complex.

The whole overflow menu currently has a few too many icons. I remember that I filed bug 1122511 a ways back about using a bottom sheet[1] for share. You could present the My Firefox stuff and perspective share intents in-line. It would make sense rather than having it in the overflow and then in My Firefox as well.

[1] https://www.google.com/design/spec/components/bottom-sheets.html

Updated

4 years ago
Blocks: 1127445
(In reply to :Margaret Leibovic from comment #2)
> I don't think we need to support this. Currently, you can hide your bookmark
> panel, but we don't disable the bookmark start. And even if you have the
> reading list panel hidden, you may want to add something to your reading
> list to read later on desktop.

I agree. Let's not try to hide all the UI if the panel is hidden. If the goal is to customized the overflow menu, then that's a separate bug/feature.
We can continue further investigation into changing the flow in bug 1122511.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.