1143042 - Switch AllocKind iteration over to range-based for loops

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

We can do this as a simple drop-in replacement once we have EnumeratedRange (bug 1142999).

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Switch AllocKind iteration over to range-based for loops.

I had to add braces in a few instances to appease MSVC. I'm not sure what the exact problem is, but I think it's something like

for (auto i : foo())
    do {
        // do stuff
    } while(0);

that it doesn't like, where the do-while is part of MOZ_ASSERT().

Comment 2

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: v1.1 - Switch AllocKind iteration over to range-based for loops.

Rebased somewhat, including on top of 1143966. I also had to add #ifdef DEBUG around one for loop that only contained an assertion, since with a range-based for loop the assertion was the only use of the variable (unlike a regular for loop, where the header itself uses the variable)! This was causing warn-as-err opt builds to burn.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e3b2557b22

(I think OSX is experiencing some infra failure - other try jobs appear similarly affected)

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8581193 [details] [diff] [review]
v1.1 - Switch AllocKind iteration over to range-based for loops.

Review of attachment 8581193 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

This needs to land along with or after bug 1142999, but it shouldn't matter in which order you apply them.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fcdeca7e548

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8fcdeca7e548