Closed Bug 1143065 Opened 11 years ago Closed 11 years ago

TEST-UNEXPECTED-FAIL | mailnews/news/test/unit/test_internalUris.js | xpcshell return code: 0

Categories

(MailNews Core :: Networking: NNTP, defect)

Product:
MailNews Core
Component:
Networking: NNTP
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 39.0

People

(Reporter: aleth, Assigned: jcranmer)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file, 1 obsolete file)

Proxy-based pseudo-class implementation
1.12 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
No description provided.
07:18:04 INFO - TEST-PASS | mailnews/news/test/unit/test_internalUris.js | test_search - [test_search : 130] 1 == 1 07:18:04 INFO - PROCESS | 27678 | 2015-03-14 07:18:04 test.test INFO [Context: test.test:4 state: finished] Finished test: test_search 07:18:04 INFO - PROCESS | 27678 | 2015-03-14 07:18:04 test.test INFO [Context: test.test:5 state: started] Starting test: test_grouplist 07:18:04 INFO - (xpcshell/head.js) | test _async_driver pending (3) 07:18:04 INFO - (xpcshell/head.js) | test _async_driver finished (3) 07:18:04 INFO - (xpcshell/head.js) | test _async_driver finished (2) 07:18:04 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "Error: __noSuchMethod__ is deprecated" {file: "resource://testing-common/mailnews/nntpd.js" line: 411}]" 07:18:04 INFO - Error console says [stackFrame Error: __noSuchMethod__ is deprecated] 07:18:04 INFO - ../../../resources/logHelper.js:_errorConsoleTunnel.observe:95 07:18:04 INFO - /builds/slave/test/build/tests/xpcshell/head.js:_do_main:207 07:18:04 INFO - /builds/slave/test/build/tests/xpcshell/head.js:_execute_test:506 07:18:04 INFO - -e:null:1 07:18:04 INFO - null:null:0 07:18:04 INFO - exiting test So, would appear to be due to bug 1140428.
Keywords: regression
OS: Mac OS X → All
http://mxr.mozilla.org/comm-central/source/mailnews/test/fakeserver/nntpd.js#411 Apparently we end up with command "" for this.parent.LIST(command+" "+args); ... which isn't found
The problem should be that instead of __noSuchMethod__ we should do something else here http://mxr.mozilla.org/comm-central/source/mailnews/test/fakeserver/nntpd.js#391 or/and fix callers.
Blocks: 1140428
Component: General → Networking: NNTP
Product: Thunderbird → MailNews Core
Seems to work for me locally - fixes this and bug 1143063. Makes us not rely on __noSuchMethod__ for inheritance. The one place with GROUP I couldn't find out how to inherit (as it would have to transfer object state too) so I just copied over those lines. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=31c6806f67dd checkin-needed if accepted
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8577782 - Flags: review?(Pidgeot18)
Comment on attachment 8577782 [details] [diff] [review] bug1143065_nntpd_noSuchMethod.patch Review of attachment 8577782 [details] [diff] [review]: ----------------------------------------------------------------- This really wants to be using ES6 classes. Unfortunately, support for that isn't ready yet (particularly the support for super which is sort of the entire reason this mess exists). After talking with jorendorff a bit over IRC, probably the best short-term fix is to just replace the sub.parent with a Proxy to sup.prototype.
Attachment #8577782 - Flags: review?(Pidgeot18) → review-
(In reply to Joshua Cranmer [:jcranmer] from comment #251) > IRC, probably the best short-term fix is to just replace the sub.parent with > a Proxy to sup.prototype. I don't know what you mean with this, and what i tried doesn't seem to work out.
Flags: needinfo?(Pidgeot18)
This is what I was referring to.
Flags: needinfo?(Pidgeot18)
Attachment #8580117 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8580117 [details] [diff] [review] Proxy-based pseudo-class implementation Review of attachment 8580117 [details] [diff] [review]: ----------------------------------------------------------------- Yep, looks like this works. r=mkmelin
Attachment #8580117 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/d796de0a725d -> FIXED
Assignee: mkmelin+mozilla → Pidgeot18
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Attachment #8577782 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: