Closed Bug 1143086 Opened 10 years ago Closed 10 years ago

Travis: Run flake8 sooner & make it abort the build immediately

Categories

(Tree Management :: Treeherder, defect, P3)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

...so people don't have to wait 5 mins to see the errors. I ummed and ahhed about doing this initially, and decided against it, since it there are pros and cons (cons being that you don't get to see the py.test results until you fix & re-push). However, I think immediate feedback is more important - and tbh people should be running it before they push anyway, so this will encourage them to do so.
The PR in bug 1139894 has a commit in there that fixes this bug.
Commit pushed to master at https://github.com/mozilla/treeherder-service https://github.com/mozilla/treeherder-service/commit/25db851ee4dd16e223ef55d4b67719e9226c2a41 Bug 1143086 - Travis: Run flake8 first & end the job early if it fails Steps in before_script (and any other part of the build lifecycle apart from 'script') terminate the run immediately on failure. This means in the case of flake8 failures, the job changes from "in progress" to "errored" virtually immediately (with the virtualenv caching changes) so the user can see the problem and re-push straight away. See: http://docs.travis-ci.com/user/build-lifecycle/
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: Treeherder: Docs & Development → TreeHerder
You need to log in before you can comment on or make changes to this bug.