1143132 - emails about redirected attachment urls link to attachment-edit instead of the actual url (mozreview, github, etc)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Gregory Szorc [:gps]]

HTML emails for review requests from MozReview look something like the following:

---

Ed Morley [:edmorley] <[e-mail]> has asked Gregory Szorc [:gps]
<[e-mail]> for review:
Bug 980986: qimportbz incorrectly prompts to overwrite patch if filename on bug
was equal to the bug number
https://bugzilla.mozilla.org/show_bug.cgi?id=980986

Attachment 8577204 [details]: MozReview Request: bz://980986/edmorley
https://bugzilla.mozilla.org/attachment.cgi?id=8577204&action=edit

---

If I click the link to the attachment, I get the attachment edit page on Bugzilla.

I'd like for the email to contain a link to the MozReview URL for the review request.

Comment 1

[Gregory Szorc [:gps]]

Multiple people told me today that this is a papercut and the necessity for following multiple links is pretty annoying. Can we get this prioritized?

Comment 2

[Mark Côté [:mcote]]

This is a problem with Bugzilla's flagmail.  We submit a comment containing a link (admittedly a little obfuscated, to the attachment itself, which redirects to the review request), which generates bugmail, but this comment is not included in the separate "review requested" flagmail.

The "easy" fix is to include a link to the attachment in addition to (or maybe even instead of) the edit link.  A better fix would be to include a comment and clearly put the link to the review request in there.  I'll talk to the bmo team.

Comment 3

[:glob ✱]

Attachment: 1143132_1.patch

- adds a hook which allows extensions to override the attachment url in flagmail
- bmo ext adds a link to reviewboard/github/gdocs url

eg.
> Attachment 8591332 [details]: MozReview Request: Bug 35 - Switch paragraph order. r?dylan
> MozReview: https://reviewboard-dev.allizom.org/r/432/
> http://bz/1143132/attachment.cgi?id=8591332&action=edit

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8629237 [details] [diff] [review]
1143132_1.patch

Review of attachment 8629237 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b46c86a..9528297  master -> master

Comment 6

[:glob ✱]

fix bustage:

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   9528297..eddd417  master -> master