Closed Bug 1143158 Opened 9 years ago Closed 7 years ago

Implement split-pane Synced Tabs home panel for iPads

Categories

(Firefox for iOS :: Home screen, defect)

All
iOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
fxios - ---

People

(Reporter: nalexander, Assigned: sachin.irukula, Mentored, NeedInfo)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
Details | Review
Probably not a v1 feature, but we would like to support split-pane Synced Tabs, with clients on the left and tabs on the right.  (Like on Android.)  This may be a good mentor bug; I don't know enough to say yet.
darrin: just surfacing this for you to be aware of.  It's not a v1 thing, but we will want split-pane mocks at some point.
This looks very difficult :(  The UIKit framework mandates that a UISplitViewController be the root controller and take the entire screen, at least in the past: http://stackoverflow.com/questions/3723342/can-a-uisplitviewcontroller-be-the-root-controller-in-a-uinavigationcontroller.  This is not feasible for a home panel.  See https://developer.apple.com/library/ios/documentation/UIKit/Reference/UISplitViewController_class/ for reference.
No longer blocks: iostabspanel
sachin: this is a more open ended, challenging ticket.  Interested?
Flags: needinfo?(sachin.irukula)
Yes, I  am interested, I will try to find more about UISplitViewController.
Flags: needinfo?(sachin.irukula)
Assignee: nobody → sachin.irukula
Just a small update on how the development is going as it has been a very long time. Added current UI its a work in progress. https://www.evernote.com/l/AN0UtWbZjchDNqf8-p-oQ0SszNfzDgPXj8Q

(In reply to Nick Alexander :nalexander from comment #3)
> sachin: this is a more open ended, challenging ticket.  Interested?
(In reply to Sachin Irukula from comment #5)
> Just a small update on how the development is going as it has been a very
> long time. Added current UI its a work in progress.
> https://www.evernote.com/l/AN0UtWbZjchDNqf8-p-oQ0SszNfzDgPXj8Q

Hey!  Progress updates are appreciated, and this looks really good!
Mentor: nalexander, sarentz
Attached file Pull Request
Attachment #8609787 - Flags: review?(nalexander)
Comment on attachment 8609787 [details] [review]
Pull Request

I'm going to redirect this review.
Attachment #8609787 - Flags: review?(sleroux)
Attachment #8609787 - Flags: review?(sarentz)
Attachment #8609787 - Flags: review?(rnewman)
Attachment #8609787 - Flags: review?(nalexander)
Sachin this looks great. But, I would like to show this to the UX team first before we land this. There are a couple of things that we need to figure out. For example empty states (what to show where), pull to refresh (where? and what happens in the empty state). Is this something we also want on the iPhone 6 Plus? (Mail.app has a similar layout in landscape there)

So, please be patient and I'll see if we can do this for v1.0. Otherwise it will very likely move to a followup release that we will do quickly after v1.0.
Flags: needinfo?(randersen)
Flags: needinfo?(dhenein)
(In reply to Stefan Arentz [:st3fan] from comment #9)
> Sachin this looks great. But, I would like to show this to the UX team first
> before we land this. There are a couple of things that we need to figure
> out. For example empty states (what to show where), pull to refresh (where?
> and what happens in the empty state). Is this something we also want on the
> iPhone 6 Plus? (Mail.app has a similar layout in landscape there)
> 
> So, please be patient and I'll see if we can do this for v1.0. Otherwise it
> will very likely move to a followup release that we will do quickly after
> v1.0.

I don't think its possible to implement this for iphone 6 plus unless there is a way of detecting current device as iphone 6 plus and handle controllers similar to the way ipad and iphone are handled currently. In mail app split view controller is the root view controller and in firefox that's not the case.
I found this on SO that might temporarily work: http://stackoverflow.com/questions/25780283/ios-how-to-detect-iphone-6-plus-iphone-6-iphone-5-by-macro

I find it strange that Apple did not take the iPhone 6/6+ in consideration when building UITraitCollection/Size classes. I feel like that's the right abstraction to use to differentiate between the screen sizes but it seems them overlooked this case when developing it :(
(In reply to Stephan Leroux [:sleroux] from comment #11)
> I found this on SO that might temporarily work:
> http://stackoverflow.com/questions/25780283/ios-how-to-detect-iphone-6-plus-
> iphone-6-iphone-5-by-macro
> 
> I find it strange that Apple did not take the iPhone 6/6+ in consideration
> when building UITraitCollection/Size classes. I feel like that's the right
> abstraction to use to differentiate between the screen sizes but it seems
> them overlooked this case when developing it :(

I found this SO during development but I didn't want to take exact size into account because that can change with the release of new iphones all the time.
Attachment #8609787 - Flags: review?(rnewman)
Adding this to triage to find out if we want to have this in V1 or not.
Comment on attachment 8609787 [details] [review]
Pull Request

Removing review flags. This can be looked at post V1.
Attachment #8609787 - Flags: review?(sleroux)
Attachment #8609787 - Flags: review?(sarentz)
Because we're skipping this for v1, I'm going to close the PR. We'll continue to track this bug, and we can either reopen the PR or rebase and open a new one.

https://github.com/mozilla/firefox-ios/pull/496
Status: NEW → ASSIGNED
OS: iOS 8 → iOS
Flags: needinfo?(dhenein)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: