1143160 - A review comment on bug 1131776 breaks splinter

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Splinter, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1131776&attachment=8569405

Try adding a comment by double-clicking a line in one of the files. Normally a comment box appears, but now I see this in the error console:

TypeError: m3 is null 10d39aa75fd233eb12f252bf61acbd28.js:930:0
  > var m3 = /^\.\.\.\s+(\d+)\s+/.exec(rawlines[i + 1]);
  > count += parseInt(m3[1], 10);

TypeError: Splinter.theReview is undefined 10d39aa75fd233eb12f252bf61acbd28.js:1433:4
  > var reviewFile = Splinter.theReview.getFile(file.filename);

This seems to happen on Chrome and older Firefox as well.

Comment 1

[:glob ✱]

looks like an issue with how splinter parses existing reviews:

  if (i < rawlines.length - 1 && rawlines[i + 1].match(/^... \d+\s+/)) {
    var m3 = /^\.\.\.\s+(\d+)\s+/.exec(rawlines[i + 1]);

that's matching
  "> + 1             // 0x10 bf f0"

looks like some unescaped periods

Comment 2

[:glob ✱]

Attachment: 1143160_1.patch

i'm not sure what this regex is actually looking for, however this should fix the error.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8578020 [details] [diff] [review]
1143160_1.patch

Review of attachment 8578020 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes the issue for me. r=dkl

Comment 4

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   27ecca5..5365c22  master -> master