Run the tests for match and matchAll on both Request objects and string URLs

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8577486 [details] [diff] [review]
Patch (v1)

Most of the changes are whitespace changes, so I'm attaching a diff -w to make the review easier.
Attachment #8577486 - Flags: review?(bkelly)
Comment on attachment 8577486 [details] [diff] [review]
Patch (v1)

Review of attachment 8577486 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Might be nice in the future to just store the item in the Cache once, and then verify same entry can be looked up with either URL or Request object.
Attachment #8577486 - Flags: review?(bkelly) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Ben Kelly [:bkelly] from comment #2)
> LGTM.  Might be nice in the future to just store the item in the Cache once,
> and then verify same entry can be looked up with either URL or Request
> object.

I mostly meant to test everything here in both cases, so that anything we add to testRequest() in the future (and there's more checks coming!) will automatically get tested in both cases...
https://hg.mozilla.org/mozilla-central/rev/84e12f76d309
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.