Closed Bug 1143193 Opened 8 years ago Closed 8 years ago

Run the tests for match and matchAll on both Request objects and string URLs

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Attached patch Patch (v1)Splinter Review
Most of the changes are whitespace changes, so I'm attaching a diff -w to make the review easier.
Attachment #8577486 - Flags: review?(bkelly)
Comment on attachment 8577486 [details] [diff] [review]
Patch (v1)

Review of attachment 8577486 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Might be nice in the future to just store the item in the Cache once, and then verify same entry can be looked up with either URL or Request object.
Attachment #8577486 - Flags: review?(bkelly) → review+
(In reply to Ben Kelly [:bkelly] from comment #2)
> LGTM.  Might be nice in the future to just store the item in the Cache once,
> and then verify same entry can be looked up with either URL or Request
> object.

I mostly meant to test everything here in both cases, so that anything we add to testRequest() in the future (and there's more checks coming!) will automatically get tested in both cases...
https://hg.mozilla.org/mozilla-central/rev/84e12f76d309
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.