1143193 - Run the tests for match and matchAll on both Request objects and string URLs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Most of the changes are whitespace changes, so I'm attaching a diff -w to make the review easier.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8577486 [details] [diff] [review]
Patch (v1)

Review of attachment 8577486 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Might be nice in the future to just store the item in the Cache once, and then verify same entry can be looked up with either URL or Request object.

Comment 3

[(no longer active)]

(In reply to Ben Kelly [:bkelly] from comment #2)
> LGTM.  Might be nice in the future to just store the item in the Cache once,
> and then verify same entry can be looked up with either URL or Request
> object.

I mostly meant to test everything here in both cases, so that anything we add to testRequest() in the future (and there's more checks coming!) will automatically get tested in both cases...

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84e12f76d309

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/84e12f76d309