Closed
Bug 1143238
Opened 9 years ago
Closed 9 years ago
Rejoining an existing MUC fails
Categories
(Chat Core :: XMPP, defect)
Tracking
(thunderbird38+ fixed)
RESOLVED
FIXED
People
(Reporter: aleth, Assigned: aleth)
Details
(Keywords: regression)
Attachments
(1 file)
2.85 KB,
patch
|
clokep
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
STR 1) Join a MUC 2) Go offline (e.g. /offline) -> MUC is correctly marked as left 3) Go online (e.g. /back) Expected behaviour: MUC is rejoined and no longer marked as left. Actual behaviour: Second MUC tab opens, both tabs are marked as left.
Assignee | ||
Comment 1•9 years ago
|
||
The jsProtoHelper change is needed so the tab sees the correct state. I think the current code tried to minimize the number of UI updates (i.e. to avoid the tab showing joining -> left -> joined). Should we complicate jsProtoHelper to only ever send a single update call, just without bugs?
Assignee | ||
Comment 2•9 years ago
|
||
This is a joining throbber regression, so we should uplift the fix.
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to aleth [:aleth] from comment #2) > This is a joining throbber regression, so we should uplift the fix. Actually it's not the joining throbber, but bug 1018771 that is to blame.
Comment 4•9 years ago
|
||
Comment on attachment 8577543 [details] [diff] [review] rejoinxmpp.diff.diff Review of attachment 8577543 [details] [diff] [review]: ----------------------------------------------------------------- Seems ok by me, and now matches the joining code.
Attachment #8577543 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/58bf649dc212
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8577543 [details] [diff] [review] rejoinxmpp.diff.diff [Approval Request Comment] Regression caused by (bug #): 1018771 User impact if declined: broken chatrooms after reconnections Risk to taking this patch (and alternatives if risky): low
Attachment #8577543 -
Flags: approval-comm-aurora?
Comment 7•9 years ago
|
||
Comment on attachment 8577543 [details] [diff] [review] rejoinxmpp.diff.diff https://hg.mozilla.org/releases/comm-aurora/rev/8c73047cec44
Attachment #8577543 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•9 years ago
|
Comment 8•9 years ago
|
||
This bug needs to be marked fixed, but I don't know the conventions in chat for setting the target milestone.
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•