1143238 - Rejoining an existing MUC fails

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

STR
1) Join a MUC
2) Go offline (e.g. /offline) -> MUC is correctly marked as left
3) Go online (e.g. /back)

Expected behaviour:
MUC is rejoined and no longer marked as left.

Actual behaviour:
Second MUC tab opens, both tabs are marked as left.

Comment 1

[aleth [:aleth]]

Attachment: rejoinxmpp.diff.diff

The jsProtoHelper change is needed so the tab sees the correct state. I think the current code tried to minimize the number of UI updates (i.e. to avoid the tab showing joining -> left -> joined). Should we complicate jsProtoHelper to only ever send a single update call, just without bugs?

Comment 2

[aleth [:aleth]]

This is a joining throbber regression, so we should uplift the fix.

Comment 3

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #2)
> This is a joining throbber regression, so we should uplift the fix.

Actually it's not the joining throbber, but bug 1018771 that is to blame.

Comment 4

[Patrick Cloke [:clokep]]

Comment on attachment 8577543 [details] [diff] [review]
rejoinxmpp.diff.diff

Review of attachment 8577543 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok by me, and now matches the joining code.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/58bf649dc212

Comment 6

[aleth [:aleth]]

Comment on attachment 8577543 [details] [diff] [review]
rejoinxmpp.diff.diff

[Approval Request Comment]
Regression caused by (bug #): 1018771
User impact if declined: broken chatrooms after reconnections
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Kent James (:rkent)]

Comment on attachment 8577543 [details] [diff] [review]
rejoinxmpp.diff.diff

https://hg.mozilla.org/releases/comm-aurora/rev/8c73047cec44

Comment 8

[Kent James (:rkent)]

This bug needs to be marked fixed, but I don't know the conventions in chat for setting the target milestone.