1143244 - jsobj.cpp:1994:20: error: implicit conversion of nullptr constant to 'bool' [-Werror,-Wnull-conversion]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning (treated as error), using clang 3.7 (though I think this warning was introduced in clang 3.6 or earlier):
{
In file included from obj/js/src/Unified_cpp_js_src8.cpp:83:
mozilla/js/src/jsobj.cpp:1994:20: error: implicit conversion of nullptr constant to 'bool' [-Werror,-Wnull-conversion]
            return nullptr;
            ~~~~~~ ^~~~~~~
}

This was added here, for bug 1135897:
http://hg.mozilla.org/mozilla-central/diff/9083621b0e2e/js/src/jsobj.cpp#l1.380

I suspect it's supposed to be "return false"?

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

bhackett, was this what you intended here?

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/514c80664661

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/514c80664661