Closed
Bug 1143271
Opened 9 years ago
Closed 8 years ago
use [ChromeOnly] on MutationObserverInit.animations
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: heycam, Assigned: smaug)
References
Details
Attachments
(1 file)
|
4.35 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Once [ChromeOnly] is supported on dictionary members, we can uncomment its use on MutationObserverInit.animations and remove the explicit chrome-caller check in nsDOMMutationObserver::Observe.
|
Assignee | |
Comment 2•8 years ago
|
||
yes. ::Observer method has currently ThreadsafeIsCallerChrome check for this.
Flags: needinfo?(bugs)
|
|
Assignee | |
Comment 3•8 years ago
|
||
I was lazy and put also the check for animation part to that test.
Assignee: nobody → bugs
|
|
Assignee | |
Comment 4•8 years ago
|
||
FWIW, getObservingInfo is [ChromeOnly] method
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8759300 [details] [diff] [review] patch r=me
Attachment #8759300 -
Flags: review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/009d5a56af0f use [ChromeOnly] on MutationObserverInit, r=bz
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/009d5a56af0f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/009d5a56af0f
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•