Closed Bug 1143271 Opened 5 years ago Closed 3 years ago

use [ChromeOnly] on MutationObserverInit.animations

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: heycam, Assigned: smaug)

References

Details

Attachments

(1 file)

Once [ChromeOnly] is supported on dictionary members, we can uncomment its use on MutationObserverInit.animations and remove the explicit chrome-caller check in nsDOMMutationObserver::Observe.
Depends on: 1141916
This still needs to happen, right?
Flags: needinfo?(bugs)
yes. ::Observer method has currently ThreadsafeIsCallerChrome check for this.
Flags: needinfo?(bugs)
Attached patch patchSplinter Review
I was lazy and put also the check for animation part to that test.
Assignee: nobody → bugs
FWIW, getObservingInfo is [ChromeOnly] method
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009d5a56af0f
use [ChromeOnly] on MutationObserverInit, r=bz
https://hg.mozilla.org/mozilla-central/rev/009d5a56af0f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.