use [ChromeOnly] on MutationObserverInit.animations

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: heycam, Assigned: smaug)

Tracking

Trunk
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Once [ChromeOnly] is supported on dictionary members, we can uncomment its use on MutationObserverInit.animations and remove the explicit chrome-caller check in nsDOMMutationObserver::Observe.
(Reporter)

Updated

4 years ago
Depends on: 1141916
This still needs to happen, right?
Flags: needinfo?(bugs)
(Assignee)

Comment 2

2 years ago
yes. ::Observer method has currently ThreadsafeIsCallerChrome check for this.
Flags: needinfo?(bugs)
(Assignee)

Comment 3

2 years ago
Created attachment 8759300 [details] [diff] [review]
patch

I was lazy and put also the check for animation part to that test.
Assignee: nobody → bugs
(Assignee)

Comment 4

2 years ago
FWIW, getObservingInfo is [ChromeOnly] method

Comment 6

2 years ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/009d5a56af0f
use [ChromeOnly] on MutationObserverInit, r=bz

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/009d5a56af0f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.