1143341 - Lock screen doesn't take into account "Require passcode after X minutes" setting anymore

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[ren0]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.5.0
Build ID: 20150225052701

Steps to reproduce:

Since the update FFOS 2.2 2015-03-10: in the item "Privacy and Security" at the Passcode Lock.


Actual results:

Something-or latency asked, when locking the code is always asked.


Expected results:

When changing of time, prise en compte de la nouvelle latence.

Comment 1

[Théo Chevalier]

Providing complete STR for this bug:

1. Open Settings > Screen lock
2. Enable Screen lock and Passcode lock, enter a new passcode
3. Set "Require passcode lock" to "After 15 minutes" for instance, then tap Ok
4. Lock the screen by pressing power button.
5. After a few seconds, press the power button again, swipe to the left to unlock

Actual result:
The phone prompts for passcode

Expected result:
The phone does NOT prompt for passcode, and should wait the amount of time defined by the user in Settings before doing so.


Tested on latest master build on Flame.
Reporter tested on Open C 2.2 build with git commit from 2015-03-10.

Asking to block on 2.2 because it's a broken feature.

Comment 2

[Théo Chevalier]

> swipe to the left to unlock

D'oh, I meant "swipe to the *right* to unlock", of course.

Comment 3

[bhavana bajaj [:bajaj]]

Adding qawanted to check if this happens on flame and also NI'ing lockscreen folks, in case they are aware of the issue.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue is occurring on the Flame 3.0

Passcode is prompted immediately even though it is set to 15 min. 

Environmental Variables:
Device: Flame 3.0(Full Flash)(KK)(319mb)
BuildID: 20150316010202
Gaia: 4868c56c0a3b7a1e51d55b24457e44a7709ea1ae
Gecko: 436686833af0
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

---------------------------------------------------------------------

This issue does not reproduce on the Flame 2.2

The passcode is not prompted immediately when set to 15 min. 

Environmental Variables:
Device: Flame 2.2(Full Flash)(KK)(319mb)
BuildID: 20150316002502
Gaia: a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko: 18619f8f6c5c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Let's get a regression window here on Flame.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

I've bisected that it's a regression of Bug 1115311. I would take a look, thanks.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

But since it's not a v2.2 bug, could we de-nominate the 2.2??

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

It's actually caused by the legacy code. In the very old version of lockscreen.js
it didn't distinguish the timer of screen off/on and locked/unlocked, so
the following code manipulate the 'unlocking' idea very trickly. In this
patch I added a new stamp to manage it.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1143341 > mozilla-b2g:master

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll set review when CI result is passed.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

OK it's green:

https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=117222d7e890

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8578456 [details] [review]
[gaia] snowmantw:bug1143341 > mozilla-b2g:master

Tim: I create a new flag to distinguish it with the 'screenOffTime'. Since in old version we bound screen on/off with locked/unlocked, so the code is weird and I now fix it.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8578456 [details] [review]
[gaia] snowmantw:bug1143341 > mozilla-b2g:master

I think it's worthy of moving these logic out of lockscreen.js but not on this bug.

Comment 13

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#BU5NoVnWQ56s79nb5TucbQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

From the latest test result after I rebased the patch it's fine, so set the flag again.

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=051c6865012c38bffbf704447ff52c4fcde7f74f

Comment 15

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a202d7025cbd79b5d95211699d3f49e4626f80e9

Comment 16

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 1.

Actual results: The phone does not prompt for passcode until it reaches the required passcode time (ex: 15 minutes) defined by the user.
See attachment: verified_v3.0.3gp
Reproduce rate: 0/10

Device: Flame v3.0 build(Verified)
Build ID               20150623010204
Gaia Revision          311c4e59936a407e64509f54fecb440d8a78e3c8
Gaia Date              2015-06-20 20:21:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/be81b8d6fae9
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150623.043033
Firmware Date          Tue Jun 23 04:30:44 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Verified)
Build ID               20150623160205
Gaia Revision          311c4e59936a407e64509f54fecb440d8a78e3c8
Gaia Date              2015-06-20 20:21:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/be81b8d6fae9
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150623.191953
Firmware Date          Tue Jun 23 19:20:11 EDT 2015
Bootloader             HHZ12f

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.3gp