1143411 - Build failure with next freetype version/current git master

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[NiLuJe]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150315132254

Steps to reproduce:

Trying to build firefox 36.0.1 against current freetype master.


Actual results:

Build failure (undefined reference to FT_Get_X11_Font_Format) when linking libxul.


Expected results:

A successful build ;).

----

In the same vein as #944454, this is caused by an upstream change touching the headers (ftxf86.h moved to ftfntfmt.h, cf. http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=0633995b558975fabe3082f50836b93d5077a03e && http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=f4d1c11faa116daad655b50828a434babbdaed2a).

The fix is as simple as adding ftfntfmt.h to the list of freetype headers in config/system-headers :).

Comment 1

[Botond Ballo [:botond]]

Thanks for the report and analysis!

> The fix is as simple as adding ftfntfmt.h to the list of freetype headers in
> config/system-headers :).

Are you interested in writing a patch that does this simple fix?

Comment 2

[NiLuJe]

Attachment: firefox-36.0.1-buildfix-ft-master.patch

Here goes :).

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8578264 [details] [diff] [review]
firefox-36.0.1-buildfix-ft-master.patch

Thanks! Requesting review from :glandium.

Comment 4

[NiLuJe]

Attachment: mozilla-central-buildfix-ft-master.patch

Reformatted patch as per guidelines.

Comment 5

[Botond Ballo [:botond]]

Added "r=glandium" to commit message and landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/afd840d66e6a

Thanks, NiLuJe!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afd840d66e6a

Comment 7

[Hussam Al-Tayeb]

Is it possible you are using the internal headers even when linking against system freetype?

Comment 8

[Alex Vincent [:WeirdAl]]

Comment on attachment 8578529 [details] [diff] [review]
mozilla-central-buildfix-ft-master.patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Users with a newer Linux configuration will not be able to build.
Fix Landed on Version: 39
Risk to taking this patch (and alternatives if risky): Unknown, but probably minimal
String or UUID changes made by this patch: None

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 9

[Alex Vincent [:WeirdAl]]

If this is what the included header looks like, it should be perfectly safe:
http://fossies.org/dox/freetype-2.6.1/ftfntfmt_8h_source.html

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8578529 [details] [diff] [review]
mozilla-central-buildfix-ft-master.patch

No impact on the final product, taking it to help packagers and developers.

Comment 11

[Carsten Book [:Tomcat]]

http://hg.mozilla.org/releases/mozilla-esr38/rev/4d0f8799beef