Closed
Bug 1143474
Opened 10 years ago
Closed 10 years ago
Remove some dead code in nsMsgSearchNews.cpp
Categories
(MailNews Core :: Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: clang-analyzer)
Attachments
(1 file)
|
2.37 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Found with scan-build:
http://people.mozilla.org/~sledru/reports/tb-scan-build-2/report-nsMsgSearchNews.cpp-EncodeTerm-44-1.html#EndPath
Attachment #8577776 -
Flags: review?(rkent)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8577776 [details] [diff] [review]
dead-code.diff
I don't know anything about the history of the #ifdef 0 code, and since this is in news I'm going to defer to Joshua.
Attachment #8577776 -
Flags: review?(rkent) → review?(Pidgeot18)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8577776 [details] [diff] [review]
dead-code.diff
Review of attachment 8577776 [details] [diff] [review]:
-----------------------------------------------------------------
Ouch. I'm reminded how much I hate this code.
Attachment #8577776 -
Flags: review?(Pidgeot18) → review+
|
Assignee | |
Updated•10 years ago
|
Severity: normal → minor
| Comment hidden (typo) |
|
|
Assignee | |
Comment 4•10 years ago
|
||
The actual changeset: https://hg.mozilla.org/comm-central/rev/766993646034
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → sledru
|
|
Assignee | |
Updated•10 years ago
|
Keywords: clang-analyzer
|
|
Assignee | |
Updated•10 years ago
|
Blocks: clang-based-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•