1143514 - SourceBuffer shouldn't be added to ActiveSourceBuffers list upon creation

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Per spec:
http://w3c.github.io/media-source/#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type

List the steps required when creating a sourcebuffer. Note that there aren't any references to ActiveSourceBuffers list.

The definition of ActiveSourceBuffers being:
http://w3c.github.io/media-source/#widl-MediaSource-activeSourceBuffers

"Contains the subset of sourceBuffers that are providing the selected video track, the enabled audio track(s), and the "showing" or "hidden" text track(s).

SourceBuffer objects in this list must appear in the same order as they appear in the sourceBuffers attribute. (e.g., If only sourceBuffers[0] and sourceBuffers[3] are in activeSourceBuffers, then activeSourceBuffers[0] must equal sourceBuffers[0] and activeSourceBuffers[1] must equal sourceBuffers[3].)
"

At creation time, the sourcebuffer object is empty, as such, it can't provide the selected video track, then enabled video track etc...

This cause failure of the webref test: media-source/mediasource-append-buffer.html

We don't support track selection, so at this stage, adding the sourcebuffer to activeSourceBuffers after a appendBuffer succeeded is probably sufficient.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Part1. Only add sourcebuffer to ActiveSourceBuffers once active

Only add sourcebuffer to ActiveSourceBuffers list once we've proccessed the first init segment.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Update webref results

Update webref results

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Part2. Update webref results

Those tests were all failing for the same reason. Wonder why it's still failing for AAC and H.264 though. Will look into it in another bug

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Update mochitest

Update mochitest to test the proper behaviour

Comment 5

[Jean-Yves Avenard [:jya]]

First post should have contained:

From W3C: http://w3c.github.io/media-source/#sourcebuffer-init-segment-received
Step 5: "If active track flag equals true, then run the following steps:

    Add this SourceBuffer to activeSourceBuffers.
    Queue a task to fire a simple event named addsourcebuffer at activeSourceBuffers
"

Comment 6

[Jean-Yves Avenard [:jya]]

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/395a1812db68
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/508c192f040e
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1922880a9d

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/395a1812db68
https://hg.mozilla.org/mozilla-central/rev/508c192f040e
https://hg.mozilla.org/mozilla-central/rev/3c1922880a9d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

To whomever it may concern, if this gets approved for uplift to Aurora, we'll probably want to revert https://hg.mozilla.org/releases/mozilla-aurora/rev/55d8ab6f1700 at that time.

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8577887 [details] [diff] [review]
Part1. Only add sourcebuffer to ActiveSourceBuffers once active

Blanket approval request for all patches in this ticket

Approval Request Comment
[Feature/regressing bug #]:1143514
[User impact if declined]: Compliance issue, tests failing.
[Describe test coverage new/current, TreeHerder]: Been in m-c for over a week.
[Risks and why]: Low. We're just being more compliant
[String/UUID change made/needed]:None

Comment 10

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/19a74d3f65ad
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/90712a460818
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/72140ae7649f
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/a16d6cee20ca