Closed Bug 1143529 Opened 5 years ago Closed 5 years ago

Stop manually calling WrapObject on DataStore instances in DataStoreService::GetDataStoresResolve

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(2 files)

They're already wrapped; see bug 1117172 comment 9.  The only reason it works it all at the moment is because of the XBL holdovers we have in binding code that we should really remove now.
Comment on attachment 8577872 [details] [diff] [review]
part 2.  Tighten up the assert in binding Wrap methods

Review of attachment 8577872 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8577872 - Flags: review?(peterv) → review+
Comment on attachment 8577871 [details] [diff] [review]
part 1.  Stop manually calling WrapObject in DataStoreService::GetDataStoresResolve

Review of attachment 8577871 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe remove the "Now what" comment. What happens is that we resolve the promise when the counter object initializes all the appended DataStores.
Attachment #8577871 - Flags: review?(amarchesini) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.