1143529 - Stop manually calling WrapObject on DataStore instances in DataStoreService::GetDataStoresResolve

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

They're already wrapped; see bug 1117172 comment 9.  The only reason it works it all at the moment is because of the XBL holdovers we have in binding code that we should really remove now.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Stop manually calling WrapObject in DataStoreService::GetDataStoresResolve

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Tighten up the assert in binding Wrap methods

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 8577872 [details] [diff] [review]
part 2.  Tighten up the assert in binding Wrap methods

Review of attachment 8577872 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8577871 [details] [diff] [review]
part 1.  Stop manually calling WrapObject in DataStoreService::GetDataStoresResolve

Review of attachment 8577871 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe remove the "Now what" comment. What happens is that we resolve the promise when the counter object initializes all the appended DataStores.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK, done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/97650ddc6032
https://hg.mozilla.org/integration/mozilla-inbound/rev/29db6bb53368

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/97650ddc6032
https://hg.mozilla.org/mozilla-central/rev/29db6bb53368