Stop manually calling WrapObject on DataStore instances in DataStoreService::GetDataStoresResolve

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments)

They're already wrapped; see bug 1117172 comment 9.  The only reason it works it all at the moment is because of the XBL holdovers we have in binding code that we should really remove now.
(Assignee)

Comment 1

4 years ago
Created attachment 8577871 [details] [diff] [review]
part 1.  Stop manually calling WrapObject in DataStoreService::GetDataStoresResolve
Attachment #8577871 - Flags: review?(amarchesini)
(Assignee)

Comment 2

4 years ago
Created attachment 8577872 [details] [diff] [review]
part 2.  Tighten up the assert in binding Wrap methods
Attachment #8577872 - Flags: review?(peterv)
Comment on attachment 8577872 [details] [diff] [review]
part 2.  Tighten up the assert in binding Wrap methods

Review of attachment 8577872 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8577872 - Flags: review?(peterv) → review+
Comment on attachment 8577871 [details] [diff] [review]
part 1.  Stop manually calling WrapObject in DataStoreService::GetDataStoresResolve

Review of attachment 8577871 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe remove the "Now what" comment. What happens is that we resolve the promise when the counter object initializes all the appended DataStores.
Attachment #8577871 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/97650ddc6032
https://hg.mozilla.org/mozilla-central/rev/29db6bb53368
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.