1143536 - product dashboard doesn't honour product visibility

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: ProductDashboard, defect)

Description

[:glob ✱]

product dashboard doesn't honour product visibility.

eg. the 'finance' product isn't in the product select, however you can always visit https://bugzilla.mozilla.org/page.cgi?id=productdashboard.html&tab=&product=Finance&bug_status=open to see the bug data (even if you aren't logged in).

Comment 1

[David Lawrence [:dkl]]

Attachment: 1143536_1.patch

Changed to can_see_product instead of can_enter_product and now die instead of allowing the code to continue if the user cannot see the product. Product needs to be MANDATORY/MANDATORY to not be visible in the product dashboard.

Please commit this before the next push if r+
 
dkl

Comment 2

[:glob ✱]

Comment on attachment 8578223 [details] [diff] [review]
1143536_1.patch

Review of attachment 8578223 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob.

i'll fix the issues on commit.

::: extensions/ProductDashboard/Extension.pm
@@ +80,3 @@
>      # We need to check and make sure that the user has permission
> +    # to see this product.
> +    my $product = new Bugzilla::Product({'name' => $product_name});

while we're touching it, we should be using the cache here.

@@ +80,5 @@
>      # We need to check and make sure that the user has permission
> +    # to see this product.
> +    my $product = new Bugzilla::Product({'name' => $product_name});
> +    if (!$product || !$user->can_see_product($product->name)) {
> +        ThrowUserError('entry_access_denied', { product => $product_name });

throwing an error that you cannot create a bug in that product doesn't make sense here.
let's just |return|

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   2d8badf..6598856  master -> master