1143577 - Status bar displays wrong icon for "silent incoming call"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

Steps to reproduce:

 1. Hold power button until menu appears
 2. Select "Silent incoming call"
 3. Notice that "vibrate" icon doesn't appear (KO)
 4. Hold power button again
 5. Select "Ring incoming call"
 6. Notice that "vibrate" icon appears (KO)

Comment 1

[Gregor Wagner [:gwagner]]

Is this a regression?

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

The expected behavior at step 3 of comment 0 is incorrect. I think the behavior on 2.2 is the expected one and not what comment 0 described.

Observed behavior on 3.0: 
"silence incoming call" enabled - no icon (DUT does NOT vibrate and does NOT ring for incoming calls)
"ring incoming call" enabled - vibrate icon appears on status bar (DUT rings and vibrates for incoming call). Depending on what user did, the mute icon would appear in place of vibrate icon.

-------------------

Observed behavior (and also EXPECTED behavior) on 2.2:
"Silence incoming call" enabled - mute icon appears (DUT does NOT vibrate and does NOT ring for incoming calls)
"Ring incoming call" enabled - no icon (DUT rings and vibrates for incoming call).

Tested on:
Device: Flame 3.0 Master
BuildID: 20150316010202
Gaia: 4868c56c0a3b7a1e51d55b24457e44a7709ea1ae
Gecko: 436686833af0
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.2
BuildID: 20150316002502
Gaia: a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko: 18619f8f6c5c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1098168 seems to have caused this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150303023847
Gaia: 6036295b7192e21c1370495617e5ab727575fea3
Gecko: 97c49ccbdfbf
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

First Broken 
Environmental Variables:
Device: Flame 3.0
BuildID: 20150303025447
Gaia: d9399ecd386aaf37214c4bffcaceca335c143413
Gecko: 11a4ffbd9ee9
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 6036295b7192e21c1370495617e5ab727575fea3
Gecko: 11a4ffbd9ee9

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: d9399ecd386aaf37214c4bffcaceca335c143413
Gecko: 97c49ccbdfbf

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/6036295b7192e21c1370495617e5ab727575fea3...d9399ecd386aaf37214c4bffcaceca335c143413

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Alive, can you take a look at this please? Looks like the landing for bug 1098168 might have caused this.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Sure, thx

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for master

The root cause is updating the wrong icon :/

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8578419 [details] [review]
patch for master

cool, thanks for the test :)

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/20aad118e4480df283fdb9019154f140b6ec10e2