1143596 - [B2G][SMS] Update correct test number in Brazil format and rewirte with Promise in test_getthreads.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

According to [1], the number format in Brazil is +55-aa-nnnnnnnn.
However, when fixing bug 914060, the test numbers in [2] was not followed.

See also bug 1136211 comment 37.

[1] http://en.wikipedia.org/wiki/Telephone_numbers_in_Brazil#Inbound
[2] https://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/tests/marionette/test_getthreads.js#355-369

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 1 v1: Provide correct test number in Brazil format. r=echen

update with correct test content.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 2 v1: Re-write with Promise.

1. Rewrite with Promise.
2. Remove checking of retrieving all messages because 
   - The sent/received message content shall already be covered in test_incoming.js and test_outgoing.js.
   - We shall focus on the verification of the attributes in thread.

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8578466 [details] [diff] [review]
Part 2 v1: Re-write with Promise.

Review of attachment 8578466 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

::: dom/mobilemessage/tests/marionette/test_getthreads.js
@@ +19,5 @@
> +  let messages = aMessages.slice(0);
> +  function saveMessage(aPromise) {
> +    let message = messages.shift();
> +    if (message) {
> +      return saveMessage(aPromise.then((message.incoming) ?

Nit: We usually don't use recursive to chain the promise, but just use iteration to make it easier to understand.

e.g.

let promise = Promise.resolve();

for (...) {
  promise = promise.then(....);
}

return promise;

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 2 v2: Re-write with Promise. r=echen

address nits in comment 3.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Mnw is green now! \o/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=584ab9a35c0e&exclusion_profile=false&filter-searchStr=Mnw

Comment 6

[Edgar Chen [:edgar]]

(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #5)
> Mnw is green now! \o/
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=584ab9a35c0e&exclusion_profile=false&filter-
> searchStr=Mnw

\o/

https://hg.mozilla.org/integration/b2g-inbound/rev/122c39b341be
https://hg.mozilla.org/integration/b2g-inbound/rev/98e74119ee84

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/122c39b341be
https://hg.mozilla.org/mozilla-central/rev/98e74119ee84