Closed Bug 1143596 Opened 5 years ago Closed 5 years ago

[B2G][SMS] Update correct test number in Brazil format and rewirte with Promise in test_getthreads.js

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
2.2 S8 (20mar)
Tracking Status
firefox39 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

Attachments

(2 files, 1 obsolete file)

According to [1], the number format in Brazil is +55-aa-nnnnnnnn.
However, when fixing bug 914060, the test numbers in [2] was not followed.

See also bug 1136211 comment 37.

[1] http://en.wikipedia.org/wiki/Telephone_numbers_in_Brazil#Inbound
[2] https://dxr.mozilla.org/mozilla-central/source/dom/mobilemessage/tests/marionette/test_getthreads.js#355-369
update with correct test content.
Attachment #8578464 - Flags: review?(echen)
1. Rewrite with Promise.
2. Remove checking of retrieving all messages because 
   - The sent/received message content shall already be covered in test_incoming.js and test_outgoing.js.
   - We shall focus on the verification of the attributes in thread.
Attachment #8578466 - Flags: review?(echen)
Attachment #8578464 - Flags: review?(echen) → review+
Comment on attachment 8578466 [details] [diff] [review]
Part 2 v1: Re-write with Promise.

Review of attachment 8578466 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

::: dom/mobilemessage/tests/marionette/test_getthreads.js
@@ +19,5 @@
> +  let messages = aMessages.slice(0);
> +  function saveMessage(aPromise) {
> +    let message = messages.shift();
> +    if (message) {
> +      return saveMessage(aPromise.then((message.incoming) ?

Nit: We usually don't use recursive to chain the promise, but just use iteration to make it easier to understand.

e.g.

let promise = Promise.resolve();

for (...) {
  promise = promise.then(....);
}

return promise;
Attachment #8578466 - Flags: review?(echen) → review+
Blocks: 1025284
Summary: [B2G][SMS] Provide correct test number in Brazil format in test_getthreads.js → [B2G][SMS] Update correct test number in Brazil format and rewirte with Promise in test_getthreads.js
address nits in comment 3.
Attachment #8578466 - Attachment is obsolete: true
Attachment #8579267 - Flags: review+
Attachment #8578464 - Attachment description: Part 1 v1: Provide correct test number in Brazil format. → Part 1 v1: Provide correct test number in Brazil format. r=echen
(In reply to Bevis Tseng[:bevistseng][:btseng] from comment #5)
> Mnw is green now! \o/
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=584ab9a35c0e&exclusion_profile=false&filter-
> searchStr=Mnw

\o/

https://hg.mozilla.org/integration/b2g-inbound/rev/122c39b341be
https://hg.mozilla.org/integration/b2g-inbound/rev/98e74119ee84
Keywords: checkin-needed
Blocks: 1081529
https://hg.mozilla.org/mozilla-central/rev/122c39b341be
https://hg.mozilla.org/mozilla-central/rev/98e74119ee84
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in before you can comment on or make changes to this bug.