1143623 - Add outerWindowID property to browser binding

Status: RESOLVED FIXED

(Toolkit :: General, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

[Tracking Requested - why for this release]:

This is an Aurora-only - Fx 39 - bug.

Bug 1077168 introduced an `outerWindowID` property to the browser binding, which we're depending on for the tab-sharing feature in Loop.
However, since this work is _not_ available in Fx 39, we'll need to port the relevant logic over to make tab-sharing work.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: add an outerWindowID property to the browser binding

Comment 2

[Mike de Boer [:mikedeboer]]

Correction: it's _Fx 38_. Thanks Mark, for pointing that out.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8577968 [details] [diff] [review]
Patch v1: add an outerWindowID property to the browser binding

Review of attachment 8577968 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8577968 [details] [diff] [review]
Patch v1: add an outerWindowID property to the browser binding

Approval Request Comment
[Feature/regressing bug #]: Loop/ Hello screensharing milestone
[User impact if declined]: User will see a new option that allows her/ him to share a window or Firefox tabs inside a room (aka. conversation). Without this patch all this won't work.
[Describe test coverage new/current, TreeHerder]: This patch was extracted from the work done in bug 1077168, which won't be uplifted to 38. Only the minimum amount of code necessary was kept here, resulting in this small patch.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.

Comment 5

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/12a35ce9fdf1