1143628 - Increasing the marionette timeout of test_massive_incoming_delete.js and also rewriting test with Promise

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a clone of Bug #1020930 +++

Increasing marionette timeout of test_massive_incoming_delete.js and also rewriting test with Promise to see if it could improve the intermittent-failure.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: Increasing the marionette timeout of test_massive_incoming_delete.js, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 2: Rewriting test_massive_incoming_delete.js with Promise, v1

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 1: Remove wrapDomRequestAsPromise defined in MobileMessage marionette test, v1

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 2-1: Increasing the marionette timeout of test_massive_incoming_delete.js, v2

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 2-2: Rewriting test_massive_incoming_delete.js with Promise, v2

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8578452 [details] [diff] [review]
Part 1: Remove wrapDomRequestAsPromise defined in MobileMessage marionette test, v1

Review of attachment 8578452 [details] [diff] [review]:
-----------------------------------------------------------------

DOMRequest now supports .then(), we don't have to wrap it as Promise any more.
Hi Bevis, may I have your review? Thank you.

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8578454 [details] [diff] [review]
Part 2-2: Rewriting test_massive_incoming_delete.js with Promise, v2

Review of attachment 8578454 [details] [diff] [review]:
-----------------------------------------------------------------

Per discussion, sending sms message one by one increases the test time, I am going to provide a new version to pipeline the request. Cancel review first.

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8578452 [details] [diff] [review]
Part 1: Remove wrapDomRequestAsPromise defined in MobileMessage marionette test, v1

Review of attachment 8578452 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks! :)

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8578453 [details] [diff] [review]
Part 2-1: Increasing the marionette timeout of test_massive_incoming_delete.js, v2

Review of attachment 8578453 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

Comment 10

[Edgar Chen [:edgar]]

Attachment: Part 2-2: Rewriting test_massive_incoming_delete.js with Promise, v3

Comment 11

[Edgar Chen [:edgar]]

Comment on attachment 8578582 [details] [diff] [review]
Part 2-2: Rewriting test_massive_incoming_delete.js with Promise, v3

Review of attachment 8578582 [details] [diff] [review]:
-----------------------------------------------------------------

Address comment #7, may I have your review, Bevis? Thank you.

Comment 12

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8578582 [details] [diff] [review]
Part 2-2: Rewriting test_massive_incoming_delete.js with Promise, v3

Review of attachment 8578582 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Thanks!

Comment 13

[Edgar Chen [:edgar]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f6f7abdeeba&exclusion_profile=false

Comment 14

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a2688ba24223
https://hg.mozilla.org/integration/b2g-inbound/rev/60fc1a10081a
https://hg.mozilla.org/integration/b2g-inbound/rev/0e7f6f2b5993

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2688ba24223
https://hg.mozilla.org/mozilla-central/rev/60fc1a10081a
https://hg.mozilla.org/mozilla-central/rev/0e7f6f2b5993