Closed Bug 1143636 Opened 10 years ago Closed 10 years ago

Allow word_list_converter.js to accpet variable word frequency information

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S8 (20mar)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

[gaia] mnjul:bug_1143636_wordlistconverter_variable_freq > mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
When I was doing bug 1102834, since we assigned uniform word frequency to user dictionary words, word_list_converter.js was programmed to have a const-value word frequency. Now, for bug 1143633's purpose, we should allow word_list_converter.js to digest word lists containing word frequencies, to and encode accordingly, to more faithfully model the behavior of xml2dict.py .
Comment on attachment 8579168 [details] [review] [gaia] mnjul:bug_1143636_wordlistconverter_variable_freq > mozilla-b2g:master Tim, please take a look. The amount of changes is actually not that scaring as apparently seen: For most parts of word_list_converter.js, I merely reverted https://github.com/mnjul/gaia-kb-dict-tools/commit/bc93f64834db996f14b24b145427d2a8e0337fdf . And at my own repo, I've got those interim commits test-covered by my own test scripts. Thanks!
Attachment #8579168 - Flags: review?(timdream)
Assignee: nobody → jlu
Status: NEW → ASSIGNED
Whiteboard: [p=1]
Target Milestone: --- → 2.2 S9 (3apr)
Attachment #8579168 - Flags: review?(timdream) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: 2.2 S9 (3apr) → 2.2 S8 (20mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: