1143660 - Python code in python/mozboot/mozboot/ should follow the flake8 convention

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Run on the mozboot source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
$ flake8 --max-line-length=220 $(find python/mozboot/mozboot/ -iname '*.py'|grep -v tests)

That should be pretty easy to fix for a beginner in Python.

One patch per kind of bug.

Comment 1

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: bz://1143660/djc

/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators

Pull down these commits:

hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610

Comment 2

[Dirkjan Ochtman (:djc)]

Sylvestre, will you review these, or should I ask someone else?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

No, I am not the code owner for this.

By the way, it would be nice to leave this kind of bug for actual beginners...

Comment 4

[Dirkjan Ochtman (:djc)]

Yeah -- sorry about that. I've picked up good first bugs in C++ before because I wasn't familiar with Mozilla's C++ code base at all, and generally I wait a bit longer to see if actual beginners come to pick it up (which often happens quite soon after the bug being mentioned on Twitter). For Python, I probably don't count as a beginner, and I could have waited longer to see if someone else would handle it.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Dirkjan, you should find a reviewer for this!

Comment 6

[Dirkjan Ochtman (:djc)]

Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc

/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators

Pull down these commits:

hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610

Comment 7

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5645/#review4917

Ship It!

Comment 8

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5647/#review4919

Ship It!

Comment 9

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5649/#review4921

Ship It!

Comment 10

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5651/#review4923

Ship It!

Comment 11

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5653/#review4925

Ship It!

Comment 12

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5655/#review4927

Ship It!

Comment 13

[Gregory Szorc [:gps]]

Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc

https://reviewboard.mozilla.org/r/5643/#review4929

Thank you very much for the cleanup! I'll accept pep8 and pyflakes changes any time.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/583035a90903
https://hg.mozilla.org/integration/fx-team/rev/9c7f64e83cd6
https://hg.mozilla.org/integration/fx-team/rev/8b2a72eea28a
https://hg.mozilla.org/integration/fx-team/rev/5a49cab8f979
https://hg.mozilla.org/integration/fx-team/rev/d15d70bbe304
https://hg.mozilla.org/integration/fx-team/rev/591e277bba50

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/583035a90903
https://hg.mozilla.org/mozilla-central/rev/9c7f64e83cd6
https://hg.mozilla.org/mozilla-central/rev/8b2a72eea28a
https://hg.mozilla.org/mozilla-central/rev/5a49cab8f979
https://hg.mozilla.org/mozilla-central/rev/d15d70bbe304
https://hg.mozilla.org/mozilla-central/rev/591e277bba50

Comment 17

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Remove unused imports from mozboot

Comment 18

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Ascertain 2 blank lines between top-level elements

Comment 19

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Fix continuation line indentations for visual indent

Comment 20

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Make sure inline comments are preceded by two spaces

Comment 21

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Remove empty lines before EOF

Comment 22

[Dirkjan Ochtman (:djc)]

Attachment: MozReview Request: Bug 1143660 - Fix spacing around operators