Closed
Bug 1143660
Opened 10 years ago
Closed 10 years ago
Python code in python/mozboot/mozboot/ should follow the flake8 convention
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: djc, Mentored)
References
Details
(Whiteboard: [good first bug][lang=Python])
Attachments
(6 files, 1 obsolete file)
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
Run on the mozboot source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
$ flake8 --max-line-length=220 $(find python/mozboot/mozboot/ -iname '*.py'|grep -v tests)
That should be pretty easy to fix for a beginner in Python.
One patch per kind of bug.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dirkjan
Assignee | ||
Comment 1•10 years ago
|
||
/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators
Pull down these commits:
hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610
Assignee | ||
Comment 2•10 years ago
|
||
Sylvestre, will you review these, or should I ask someone else?
Reporter | ||
Comment 3•10 years ago
|
||
No, I am not the code owner for this.
By the way, it would be nice to leave this kind of bug for actual beginners...
Assignee | ||
Comment 4•10 years ago
|
||
Yeah -- sorry about that. I've picked up good first bugs in C++ before because I wasn't familiar with Mozilla's C++ code base at all, and generally I wait a bit longer to see if actual beginners come to pick it up (which often happens quite soon after the bug being mentioned on Twitter). For Python, I probably don't count as a beginner, and I could have waited longer to see if someone else would handle it.
Reporter | ||
Comment 5•10 years ago
|
||
Dirkjan, you should find a reviewer for this!
Flags: needinfo?(dirkjan)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc
/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators
Pull down these commits:
hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610
Attachment #8579502 -
Flags: review?(gps)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(dirkjan)
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Comment 9•10 years ago
|
||
Comment 10•10 years ago
|
||
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc
https://reviewboard.mozilla.org/r/5643/#review4929
Thank you very much for the cleanup! I'll accept pep8 and pyflakes changes any time.
Attachment #8579502 -
Flags: review?(gps) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 14•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/583035a90903
https://hg.mozilla.org/integration/fx-team/rev/9c7f64e83cd6
https://hg.mozilla.org/integration/fx-team/rev/8b2a72eea28a
https://hg.mozilla.org/integration/fx-team/rev/5a49cab8f979
https://hg.mozilla.org/integration/fx-team/rev/d15d70bbe304
https://hg.mozilla.org/integration/fx-team/rev/591e277bba50
Keywords: checkin-needed
Whiteboard: [good first bug][lang=Python] → [good first bug][lang=Python][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/583035a90903
https://hg.mozilla.org/mozilla-central/rev/9c7f64e83cd6
https://hg.mozilla.org/mozilla-central/rev/8b2a72eea28a
https://hg.mozilla.org/mozilla-central/rev/5a49cab8f979
https://hg.mozilla.org/mozilla-central/rev/d15d70bbe304
https://hg.mozilla.org/mozilla-central/rev/591e277bba50
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=Python][fixed-in-fx-team] → [good first bug][lang=Python]
Target Milestone: --- → Firefox 39
Assignee | ||
Comment 16•9 years ago
|
||
Attachment #8579502 -
Attachment is obsolete: true
Attachment #8619759 -
Flags: review+
Attachment #8619760 -
Flags: review+
Attachment #8619761 -
Flags: review+
Attachment #8619762 -
Flags: review+
Attachment #8619763 -
Flags: review+
Attachment #8619764 -
Flags: review+
Assignee | ||
Comment 17•9 years ago
|
||
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Assignee | ||
Comment 20•9 years ago
|
||
Assignee | ||
Comment 21•9 years ago
|
||
Assignee | ||
Comment 22•9 years ago
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 39 → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•