Closed Bug 1143660 Opened 5 years ago Closed 5 years ago

Python code in python/mozboot/mozboot/ should follow the flake8 convention

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: Sylvestre, Assigned: djc, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=Python])

Attachments

(6 files, 1 obsolete file)

Run on the mozboot source code, the following line shows a bunch of warnings. Nothing critical but it would be nice to remove them:
$ flake8 --max-line-length=220 $(find python/mozboot/mozboot/ -iname '*.py'|grep -v tests)

That should be pretty easy to fix for a beginner in Python.

One patch per kind of bug.
Assignee: nobody → dirkjan
Attached file MozReview Request: bz://1143660/djc (obsolete) —
/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators

Pull down these commits:

hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610
Sylvestre, will you review these, or should I ask someone else?
No, I am not the code owner for this.

By the way, it would be nice to leave this kind of bug for actual beginners...
Yeah -- sorry about that. I've picked up good first bugs in C++ before because I wasn't familiar with Mozilla's C++ code base at all, and generally I wait a bit longer to see if actual beginners come to pick it up (which often happens quite soon after the bug being mentioned on Twitter). For Python, I probably don't count as a beginner, and I could have waited longer to see if someone else would handle it.
Dirkjan, you should find a reviewer for this!
Flags: needinfo?(dirkjan)
Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc

/r/5645 - Bug 1143660 - Remove unused imports from mozboot
/r/5647 - Bug 1143660 - Ascertain 2 blank lines between top-level elements
/r/5649 - Bug 1143660 - Fix continuation line indentations for visual indent
/r/5651 - Bug 1143660 - Make sure inline comments are preceded by two spaces
/r/5653 - Bug 1143660 - Remove empty lines before EOF
/r/5655 - Bug 1143660 - Fix spacing around operators

Pull down these commits:

hg pull review -r 78368fba69448020f66c75c22fd5465bd34dd610
Attachment #8579502 - Flags: review?(gps)
Flags: needinfo?(dirkjan)
Comment on attachment 8579502 [details]
MozReview Request: bz://1143660/djc

https://reviewboard.mozilla.org/r/5643/#review4929

Thank you very much for the cleanup! I'll accept pep8 and pyflakes changes any time.
Attachment #8579502 - Flags: review?(gps) → review+
Keywords: checkin-needed
Blocks: flake8
Attachment #8579502 - Attachment is obsolete: true
Attachment #8619759 - Flags: review+
Attachment #8619760 - Flags: review+
Attachment #8619761 - Flags: review+
Attachment #8619762 - Flags: review+
Attachment #8619763 - Flags: review+
Attachment #8619764 - Flags: review+
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 39 → mozilla39
You need to log in before you can comment on or make changes to this bug.