Gtk3 - use margin for scrollbar thumb

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

Trunk
mozilla39
All
Linux
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Scrollbars in GTK3-based Firefox are too wide and not consistent with the rest of the desktop (GNOME). In Fedora 21, they looked the same as scrollbars rendered by GTK.
It's apparently caused by changes in the Adwaita theme between 3.12 and 3.14 because webkitgtk suffers from the same problem and renders the same wide scrollbars. They already have it reported upstream: https://bugs.webkit.org/show_bug.cgi?id=140800

Firefox should ideally have the new overlay scrollbars, or at least classic scrollbars that have the same width like in Fedora 21.

I also opened the bug in GNOME upstream. They might provide some guidance there how to fix it: https://bugzilla.gnome.org/show_bug.cgi?id=746114

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1201527
(Assignee)

Comment 1

4 years ago
Created attachment 8578045 [details] [diff] [review]
scrollbar.patch

Karl, this one should be trivial. The code change is derived from gtk_range_draw() in gtk+-3.15.11/gtk/gtkrange.c.
Attachment #8578045 - Flags: review?(karlt)
(Assignee)

Comment 3

4 years ago
Thanks! No need to test try - the gtk3 code is not build by gtk2 try servers.
Keywords: checkin-needed
Please *do* test on try, with this patch: https://bug1016641.bugzilla.mozilla.org/attachment.cgi?id=8444892
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
Mike, it does not seem to be working. Do I miss something?

06:04:04     INFO -  checking for gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 ... Requested 'gtk+-3.0 >= 3.4.0' but version of GTK+ is 3.0.12
06:04:04     INFO -  configure: error: Library requirements (gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 ) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.
Flags: needinfo?(mh+mozilla)
gah, we need gtk 3.4, now. Let me update the gtk package and the patch. (btw, no need for a -u all for those pushes, the result is not worth it, except if you expect to fix some of them)
Flags: needinfo?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #7)
> gah, we need gtk 3.4, now. Let me update the gtk package and the patch.

huh, the package *does* have 3.4.4. wtf?
Comment hidden (obsolete)
(Assignee)

Comment 12

4 years ago
Builds fine.
Keywords: checkin-needed
Can we get a Try run that doesn't have failing gtests please? :)
Keywords: checkin-needed
Gtk3 try builds always fail gtests at the moment.
Keywords: checkin-needed
(In reply to Mike Hommey [:glandium] from comment #14)
> Gtk3 try builds always fail gtests at the moment.

(bug 1072902 fwiw)
https://hg.mozilla.org/mozilla-central/rev/300c3b73ff8d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.