1143686 - Gtk3 - use margin for scrollbar thumb

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Scrollbars in GTK3-based Firefox are too wide and not consistent with the rest of the desktop (GNOME). In Fedora 21, they looked the same as scrollbars rendered by GTK.
It's apparently caused by changes in the Adwaita theme between 3.12 and 3.14 because webkitgtk suffers from the same problem and renders the same wide scrollbars. They already have it reported upstream: https://bugs.webkit.org/show_bug.cgi?id=140800

Firefox should ideally have the new overlay scrollbars, or at least classic scrollbars that have the same width like in Fedora 21.

I also opened the bug in GNOME upstream. They might provide some guidance there how to fix it: https://bugzilla.gnome.org/show_bug.cgi?id=746114

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1201527

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: scrollbar.patch

Karl, this one should be trivial. The code change is derived from gtk_range_draw() in gtk+-3.15.11/gtk/gtkrange.c.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8578045 [details] [diff] [review]
scrollbar.patch

https://git.gnome.org/browse/gtk+/commit/gtk/gtkrange.c?id=5108a27e6c4d77bb92b1f80d548b8f6994a68b89

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Thanks! No need to test try - the gtk3 code is not build by gtk2 try servers.

Comment 4

[Mike Hommey [:glandium]]

Please *do* test on try, with this patch: https://bug1016641.bugzilla.mozilla.org/attachment.cgi?id=8444892

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Ok, the try is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba3260d0bc64

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Mike, it does not seem to be working. Do I miss something?

06:04:04     INFO -  checking for gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 ... Requested 'gtk+-3.0 >= 3.4.0' but version of GTK+ is 3.0.12
06:04:04     INFO -  configure: error: Library requirements (gtk+-3.0 >= 3.4.0 gtk+-unix-print-3.0 glib-2.0 gobject-2.0 ) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.

Comment 7

[Mike Hommey [:glandium]]

gah, we need gtk 3.4, now. Let me update the gtk package and the patch. (btw, no need for a -u all for those pushes, the result is not worth it, except if you expect to fix some of them)

Comment 8

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #7)
> gah, we need gtk 3.4, now. Let me update the gtk package and the patch.

huh, the package *does* have 3.4.4. wtf?

Comment 9

[Mike Hommey [:glandium]]

Okay, so *this* is the right patch:
https://bug1016641.bugzilla.mozilla.org/attachment.cgi?id=8579124

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Ok, next try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aaf6d171b7e

Comment 11

[Martin Stránský [:stransky] (ni? me)]

With an updated tree: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3beeba840481

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Builds fine.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Can we get a Try run that doesn't have failing gtests please? :)

Comment 14

[Mike Hommey [:glandium]]

Gtk3 try builds always fail gtests at the moment.

Comment 15

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #14)
> Gtk3 try builds always fail gtests at the moment.

(bug 1072902 fwiw)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/300c3b73ff8d

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/300c3b73ff8d