1143714 - Throttle environment changes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Benjamin Smedberg]

If a user is disabling multiple addons quickly in a row, or making other changes, we will end up sending very short subsession pings for each change. This is not desirable.

I believe we should throttle environment changes so that they happen at most once every N minutes (suggest N=5). In detail this is how I think it should work:

* when we receive the "first" change notification, immediately reset/start a new subsession.
* Any subsequent change that happens within N minutes should not reset the subsession but should update the environment block of the existing subsession.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Stealing.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Attachment: Throttle environment changes

This throttles the environment changes to only fire if there was no change in the last 5 minutes.
Most of the patch is test updates.

Comment 3

[Vladan Djeric (:vladan)]

Gonna wait for clarifications on the other patch https://bugzilla.mozilla.org/show_bug.cgi?id=1140558#c36

Comment 4

[Georg Fritzsche [:gfritzsche]]

Attachment: Throttle environment changes

Rebased, part of this stack: https://pastebin.mozilla.org/8827100

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 8583139 [details] [diff] [review]
Throttle environment changes

Review of attachment 8583139 [details] [diff] [review]:
-----------------------------------------------------------------

r+ once the test question is addressed

::: toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
@@ +937,5 @@
> +  fakeNow(gNow);
> +  Preferences.set(PREF_TEST, 3);
> +  yield deferred.promise;
> +
> +  Assert.equal(changeCount, 2);

will this be 2 because of the throttling happening in _onEnvironmentChange or in _checkForAddonChanges? i.e. which message gets printed to the console

Comment 6

[Georg Fritzsche [:gfritzsche]]

(In reply to Vladan Djeric (:vladan) -- please needinfo! from comment #5)
> ::: toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js
> @@ +937,5 @@
> > +  fakeNow(gNow);
> > +  Preferences.set(PREF_TEST, 3);
> > +  yield deferred.promise;
> > +
> > +  Assert.equal(changeCount, 2);
> 
> will this be 2 because of the throttling happening in _onEnvironmentChange
> or in _checkForAddonChanges? i.e. which message gets printed to the console

Because of the throttling in _onEnvironmentChange:
> TelemetryEnvironment::_onEnvironmentChange - throttling changes, now: Mon Feb 01 2010 13:41:00 GMT+0100 (CET), last change: Mon Feb 01 2010 13:40:00 GMT+0100 (CET)

Pref changes are not discarded for pending addon updates, only the addon/plugin/experiment changes go through there.

Comment 7

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/fx-team/rev/756c80951bbb

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for shutdown crashes:
https://hg.mozilla.org/integration/fx-team/rev/1d92657d70e5

Comment 9

[Georg Fritzsche [:gfritzsche]]

Being handled in bug 1139460.

Comment 10

[Georg Fritzsche [:gfritzsche]]

try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=256df1f0f2f6
fxteam push: https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=d2567d89cda3

https://hg.mozilla.org/integration/fx-team/rev/fdf9d0174142

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This and everything else from that push is backed out in https://hg.mozilla.org/integration/fx-team/rev/6901a267f856 for Windows PGO XPCShell failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=2520751&repo=fx-team

Comment 12

[Georg Fritzsche [:gfritzsche]]

See bug 1139460.

Comment 13

[Georg Fritzsche [:gfritzsche]]

fx-team push: https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=cda9f6c087a6
pgo try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cb8ce2e0436
previous full try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=256df1f0f2f6

https://hg.mozilla.org/integration/fx-team/rev/911d0d7068d6

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/911d0d7068d6

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8583139 [details] [diff] [review]
Throttle environment changes

Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43.

Comment 16

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97b36b7bcf86