1143759 - share plane in quick share menu is too big

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

From the changes in bug 1122302.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: centerInside

Is this what you were looking for, Anthony? This is what it was originally.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8578125 [details]
centerInside

Awesome! this is great.

This aligns with it's fellow quick share icons much better!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1143759/mcomella

/r/5477 - Bug 1143759 - Change scaleType of quick share action bar to centerInside. r=liuche

Pull down this commit:

hg pull review -r 16d2ae99b2cff85c4ab4c8f4f4e32a3e0cdf92e7

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8578222 [details]
MozReview Request: bz://1143759/mcomella

https://reviewboard.mozilla.org/r/5475/#review4417

Ship It!

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/9b2c3bee895c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b2c3bee895c

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-03-19-14-46-14.png

Is this issue fixed?
This is how the share plane looks like in quick share menu on latest Nightly:
Firefox for Android 39.0a1 (2015-03-18) using a Nexus 4 (Android 4.4)

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(re comment 7)

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8578222 [details]
MozReview Request: bz://1143759/mcomella

This should get uplifted with bug 1122302 - I will handle the uplift.

Approval Request Comment
[Feature/regressing bug #]: bug 1122302
[User impact if declined]:
  Users will see the share plane icon in the quick share menu as larger than desired - i.e. polish.

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  We change the attribute determining how icons are scaled in the quick share menu - this could, in theory, backfire, but since we're dealing with equal-sized application icons, there should be no issues. 

[String/UUID change made/needed]: None

Comment 10

[Teodora Vermesan (:TeoVermesan)]

I've installed the 16-03 Nightly build and the icon looked bigger: http://i.imgur.com/4l7pnvM.png
The actual display is the one in comment 7. So I will mark status-firefox 39 as verified.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fbf1c776fa91

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed using:
Device: Samsung S5 (Android 4.4)
Build: Firefox for Android 38.0a2 (2015-03-26)

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1143759 - Change scaleType of quick share action bar to centerInside. r=liuche